* [PATCH net] gve: Copy and paste buy in gve_get_stats()
@ 2019-08-20 9:00 Dan Carpenter
2019-08-20 9:11 ` [PATCH v2 net] gve: Copy and paste bug " Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2019-08-20 9:00 UTC (permalink / raw)
To: Catherine Sullivan
Cc: Sagi Shahar, Jon Olson, David S. Miller, Willem de Bruijn,
Luigi Rizzo, Chuhong Yuan, netdev, kernel-janitors
There is a copy and paste error so we have "rx" where "tx" was intended
in the priv->tx[] array.
Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/google/gve/gve_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
index 497298752381..aca95f64bde8 100644
--- a/drivers/net/ethernet/google/gve/gve_main.c
+++ b/drivers/net/ethernet/google/gve/gve_main.c
@@ -50,7 +50,7 @@ static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s)
u64_stats_fetch_begin(&priv->tx[ring].statss);
s->tx_packets += priv->tx[ring].pkt_done;
s->tx_bytes += priv->tx[ring].bytes_done;
- } while (u64_stats_fetch_retry(&priv->rx[ring].statss,
+ } while (u64_stats_fetch_retry(&priv->tx[ring].statss,
start));
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2 net] gve: Copy and paste bug in gve_get_stats()
2019-08-20 9:00 [PATCH net] gve: Copy and paste buy in gve_get_stats() Dan Carpenter
@ 2019-08-20 9:11 ` Dan Carpenter
2019-08-21 17:20 ` Catherine Sullivan
2019-08-22 3:50 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-08-20 9:11 UTC (permalink / raw)
To: Catherine Sullivan
Cc: Sagi Shahar, Jon Olson, David S. Miller, Willem de Bruijn,
Luigi Rizzo, Chuhong Yuan, netdev, kernel-janitors
There is a copy and paste error so we have "rx" where "tx" was intended
in the priv->tx[] array.
Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: fix a typo in the subject: buy -> bug (Thanks Walter Harms)
drivers/net/ethernet/google/gve/gve_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
index 497298752381..aca95f64bde8 100644
--- a/drivers/net/ethernet/google/gve/gve_main.c
+++ b/drivers/net/ethernet/google/gve/gve_main.c
@@ -50,7 +50,7 @@ static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s)
u64_stats_fetch_begin(&priv->tx[ring].statss);
s->tx_packets += priv->tx[ring].pkt_done;
s->tx_bytes += priv->tx[ring].bytes_done;
- } while (u64_stats_fetch_retry(&priv->rx[ring].statss,
+ } while (u64_stats_fetch_retry(&priv->tx[ring].statss,
start));
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 net] gve: Copy and paste bug in gve_get_stats()
2019-08-20 9:11 ` [PATCH v2 net] gve: Copy and paste bug " Dan Carpenter
@ 2019-08-21 17:20 ` Catherine Sullivan
2019-08-22 3:50 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Catherine Sullivan @ 2019-08-21 17:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sagi Shahar, Jon Olson, David S. Miller, Willem de Bruijn,
Luigi Rizzo, Chuhong Yuan, netdev, kernel-janitors
On Tue, Aug 20, 2019 at 2:11 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> There is a copy and paste error so we have "rx" where "tx" was intended
> in the priv->tx[] array.
>
> Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: fix a typo in the subject: buy -> bug (Thanks Walter Harms)
>
> drivers/net/ethernet/google/gve/gve_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
> index 497298752381..aca95f64bde8 100644
> --- a/drivers/net/ethernet/google/gve/gve_main.c
> +++ b/drivers/net/ethernet/google/gve/gve_main.c
> @@ -50,7 +50,7 @@ static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s)
> u64_stats_fetch_begin(&priv->tx[ring].statss);
> s->tx_packets += priv->tx[ring].pkt_done;
> s->tx_bytes += priv->tx[ring].bytes_done;
> - } while (u64_stats_fetch_retry(&priv->rx[ring].statss,
> + } while (u64_stats_fetch_retry(&priv->tx[ring].statss,
> start));
> }
> }
> --
> 2.20.1
Thanks!
Reviewed-by: Catherine Sullivan <csully@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 net] gve: Copy and paste bug in gve_get_stats()
2019-08-20 9:11 ` [PATCH v2 net] gve: Copy and paste bug " Dan Carpenter
2019-08-21 17:20 ` Catherine Sullivan
@ 2019-08-22 3:50 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2019-08-22 3:50 UTC (permalink / raw)
To: dan.carpenter
Cc: csully, sagis, jonolson, willemb, lrizzo, hslester96, netdev,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 20 Aug 2019 12:11:44 +0300
> There is a copy and paste error so we have "rx" where "tx" was intended
> in the priv->tx[] array.
>
> Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: fix a typo in the subject: buy -> bug (Thanks Walter Harms)
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-22 3:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-20 9:00 [PATCH net] gve: Copy and paste buy in gve_get_stats() Dan Carpenter
2019-08-20 9:11 ` [PATCH v2 net] gve: Copy and paste bug " Dan Carpenter
2019-08-21 17:20 ` Catherine Sullivan
2019-08-22 3:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).