From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D59C3A59D for ; Tue, 20 Aug 2019 11:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 797E522DA8 for ; Tue, 20 Aug 2019 11:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729874AbfHTLue (ORCPT ); Tue, 20 Aug 2019 07:50:34 -0400 Received: from mga17.intel.com ([192.55.52.151]:34298 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729684AbfHTLue (ORCPT ); Tue, 20 Aug 2019 07:50:34 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Aug 2019 04:50:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,408,1559545200"; d="scan'208";a="183176160" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 20 Aug 2019 04:50:31 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1i02el-000HTe-53; Tue, 20 Aug 2019 19:50:31 +0800 Date: Tue, 20 Aug 2019 19:50:16 +0800 From: kbuild test robot To: =?unknown-8bit?B?QmrDtnJuIFTDtnBlbA==?= Cc: kbuild-all@01.org, Daniel Borkmann , Magnus Karlsson , Jonathan Lemon , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH] xsk: fix ptr_ret.cocci warnings Message-ID: <20190820115016.i6uuadjmqrr2iunt@48261080c7f1> References: <201908201913.pObcBf2Z%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201908201913.pObcBf2Z%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: kbuild test robot kernel/bpf/xskmap.c:24:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 0402acd683c6 ("xsk: remove AF_XDP socket from map when the socket is released") CC: Björn Töpel Signed-off-by: kbuild test robot --- tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git master head: 54c851a8cc739ce7f1aaea583940054cdfe2223f commit: 0402acd683c678874df6bdbc23530ca07ea19353 [7165/7710] xsk: remove AF_XDP socket from map when the socket is released xskmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/bpf/xskmap.c +++ b/kernel/bpf/xskmap.c @@ -21,7 +21,7 @@ int xsk_map_inc(struct xsk_map *map) struct bpf_map *m = &map->map; m = bpf_map_inc(m, false); - return IS_ERR(m) ? PTR_ERR(m) : 0; + return PTR_ERR_OR_ZERO(m); } void xsk_map_put(struct xsk_map *map)