From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 917AEC3A59D for ; Tue, 20 Aug 2019 16:34:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 675C52339D for ; Tue, 20 Aug 2019 16:34:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="py9/BlWS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730338AbfHTQeg (ORCPT ); Tue, 20 Aug 2019 12:34:36 -0400 Received: from vps.xff.cz ([195.181.215.36]:35884 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729888AbfHTQef (ORCPT ); Tue, 20 Aug 2019 12:34:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1566318873; bh=3EWCt3iq/B/vjAGtGo7IXhuRxxDcIZbWkjIAdRe7UbM=; h=Date:From:To:Cc:Subject:References:X-My-GPG-KeyId:From; b=py9/BlWS5YpsBC+Ob1OADS/v6gNrFJh+2R35taWE4l0I08LKPhR6sIH0qcyRfrwtM D+LAbXmPoRgIIHlVbnEhG9sWzKZjHzCiCDJvoT0n1SFpumVjMj9nJcsicSkkJYd2KT z9lPeAk6WE7kRV2NWjKB/Q62TU5tZqBALJK8kweQ= Date: Tue, 20 Aug 2019 18:34:33 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Rob Herring Cc: "David S. Miller" , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , netdev , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 2/6] dt-bindings: net: sun8i-a83t-emac: Add phy-io-supply property Message-ID: <20190820163433.sr4lvjxmmhjtbtcb@core.my.home> Mail-Followup-To: Rob Herring , "David S. Miller" , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , netdev , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com References: <20190820145343.29108-1-megous@megous.com> <20190820145343.29108-3-megous@megous.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 20, 2019 at 11:20:22AM -0500, Rob Herring wrote: > On Tue, Aug 20, 2019 at 9:53 AM wrote: > > > > From: Ondrej Jirman > > > > Some PHYs require separate power supply for I/O pins in some modes > > of operation. Add phy-io-supply property, to allow enabling this > > power supply. > > Perhaps since this is new, such phys should have *-supply in their nodes. Yes, I just don't understand, since external ethernet phys are so common, and they require power, how there's no fairly generic mechanism for this already in the PHY subsystem, or somewhere? It looks like other ethernet mac drivers also implement supplies on phys on the EMAC nodes. Just grep phy-supply through dt-bindings/net. Historical reasons, or am I missing something? It almost seems like I must be missing something, since putting these properties to phy nodes seems so obvious. thank you and regards, Ondrej > > > > Signed-off-by: Ondrej Jirman > > --- > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 4 ++++ > > 1 file changed, 4 insertions(+)