From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1331C3A589 for ; Tue, 20 Aug 2019 18:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4B2920644 for ; Tue, 20 Aug 2019 18:11:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="m0wbJYW+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730215AbfHTSLN (ORCPT ); Tue, 20 Aug 2019 14:11:13 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60835 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727358AbfHTSLN (ORCPT ); Tue, 20 Aug 2019 14:11:13 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DD21D21443; Tue, 20 Aug 2019 14:11:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 20 Aug 2019 14:11:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=wIvSUF SxBtKrLx7QW6izXj5arwDQX+RuLbQJMChRUnQ=; b=m0wbJYW+y0sMPQSHCjrZwg SQfdBzqc4G9vlAj4sIhdJ8yeReIPGWHJGROL4WecWDVhUdIz//euBTr6BQxvEMSH OD/PPC+QMZ3Jcqnzk6kJLDK3/Ti5fle09KBGF1+rgi1ykEkSBiXLF3AC/UOXXFXt Bgj7P4smZm0bxUgeHmTD57qSVfEeHDzDqJ3VjtulJdKLAxtEVweEY8S8YMSFxuj/ EGszuc6EDo+A9+Q+ZVeXZ6h+uqeP1+mmuWJQgj5TW4tgrtLIB45nnxaibjTMgI8g EtJ1G4txAeI+Juxa0Qm28DRPbF+aCWl33LYOy0q1ugeEyhEOg8deX8+BZnkld8lQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudeguddguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesth dtredttdervdenucfhrhhomhepkfguohcuufgthhhimhhmvghluceoihguohhstghhsehi ughoshgthhdrohhrgheqnecukfhppeejjedrudefkedrvdegledrvddtleenucfrrghrrg hmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrghenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Received: from localhost (unknown [77.138.249.209]) by mail.messagingengine.com (Postfix) with ESMTPA id D3E82380089; Tue, 20 Aug 2019 14:11:09 -0400 (EDT) Date: Tue, 20 Aug 2019 21:10:55 +0300 From: Ido Schimmel To: YueHaibing Cc: davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, mcroce@redhat.com, jakub.kicinski@netronome.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next] netdevsim: Fix build error without CONFIG_INET Message-ID: <20190820181055.GA6054@splinter> References: <20190819120825.74460-1-yuehaibing@huawei.com> <20190820141446.71604-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190820141446.71604-1-yuehaibing@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 20, 2019 at 10:14:46PM +0800, YueHaibing wrote: > If CONFIG_INET is not set, building fails: > > drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': > dev.c:(.text+0x67b): undefined reference to `ip_send_check' > > Use ip_fast_csum instead of ip_send_check to avoid > dependencies on CONFIG_INET. > > Reported-by: Hulk Robot > Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") > Signed-off-by: YueHaibing Reviewed-by: Ido Schimmel Tested-by: Ido Schimmel Thanks for fixing this in my stead!