Re: [pull request][net-next v2 00/16] Mellanox, mlx5 devlink RX health reporters

[Jakub Kicinski <jakub.kicinski@netronome.com>]

On Tue, 20 Aug 2019 20:24:10 +0000, Saeed Mahameed wrote:
> This patchset introduces changes in mlx5 devlink health reporters.
> The highlight of these changes is adding a new reporter: RX reporter
> 
> mlx5 RX reporter: reports and recovers from timeouts and RX completion
> error.
> 
> 1) Perform TX reporter cleanup. In order to maintain the
> code flow as similar as possible between RX and TX reporters, start the
> set with cleanup.
> 
> 2) Prepare for code sharing, generalize and move shared
> functionality.
> 
> 3) Refactor and extend TX reporter diagnostics information
> to align the TX reporter diagnostics output with the RX reporter's
> diagnostics output.
> 
> 4) Add helper functions Patch 11: Add RX reporter, initially
> supports only the diagnostics call back.
> 
> 5) Change ICOSQ (Internal Operations Send Queue) open/close flow to
> avoid race between interface down and completion error recovery.
> 
> 6) Introduce recovery flows for RX ring population timeout on ICOSQ,
> and for completion errors on ICOSQ and on RQ (Regular receive queues).
> 
> 7) Include RX reporters in mlx5 documentation.
> 
> 8) Last two patches of this series, are trivial fixes for previously
> submitted patches on this release cycle.

Not really something I can competently ack, but FWIW doesn't raise any
red flags for me.