From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5612CC3A59E for ; Wed, 21 Aug 2019 03:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2768C206BA for ; Wed, 21 Aug 2019 03:30:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pBbwwTaE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727332AbfHUDaa (ORCPT ); Tue, 20 Aug 2019 23:30:30 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:36978 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727263AbfHUDa3 (ORCPT ); Tue, 20 Aug 2019 23:30:29 -0400 Received: by mail-qk1-f195.google.com with SMTP id s14so652309qkm.4 for ; Tue, 20 Aug 2019 20:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=sq9fx9GMYh90EDNp9r48nydmLa8jqoUXCcyh9dQly6k=; b=pBbwwTaEscuJuxf7vRk5dv9JRDy7ovrWJJ86vpGlbJtjoYtWqTfKZR5XHyQaHUKIM/ D43u9c9ugl0+u8YUCrJ/EWQTSa13OCiFDJv9sLym2U1ZxXtE8lWDzTvQqWtXT0bTRZpN 8IabeNlvOi2KSqdEdiutWGwv8kDKIZc9ObXDeHFgw4Hq7thni94pwHoDdI5fXrNM2C2V vukSzqn5gmz2MjurbUZmOv9Q+JgbtCpSvrSrOagDp7QvNJ0uF+hoxBVztu/A2jtjClzM qqkWLZi9LEDwU9zeM0/Cyp49l3uX5B81QlTDNhVXi/D7b9s9xGsCSpWiv9hl8uBp0Sjb QzYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=sq9fx9GMYh90EDNp9r48nydmLa8jqoUXCcyh9dQly6k=; b=jomB/BtuJNw9cCOxe5R+yb9VBugKIPuzl9XbZxKCz7RZ+ln/ekMcEoFfbaht7/5s05 4hanUJw9XolZvoiZSghAOm+BW21fUuS+mUcDHRMVSk+fpQ/OhSLypnhtYw1m2CkQaH3P PILzDeQFEEt4CLcmMvWOZ/aErismyPRr93X1pKjv9ejIKPTP7msXInmA7/mxPJpE2Rg+ eIetltoNc9LA8i8enSPiebSP0idQ2UtQABPGx2icMZj+MQDfvOChFXHhqdm3Zl635BXm lZx6EXlBESYtpApgWBfc5Tx3fQzH77xQBTHqYEPOGVgnLocE75lFyoKdDg8UykmJ09CW HURA== X-Gm-Message-State: APjAAAV+5K8+BdmJnn3H52kC2PQnAV/vCXEJ+HVS1JaoTCUlf5pzf6rF vMn/vHp55SzdYc/3V78RDgA= X-Google-Smtp-Source: APXvYqxX3JFmjhUtu5PDsvyozFbmjtgAET1HnGMsoLIioV4jHF6pc9HaP4qGanO9yktFjyuzJgOVQg== X-Received: by 2002:a37:a2d1:: with SMTP id l200mr29440535qke.63.1566358228843; Tue, 20 Aug 2019 20:30:28 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id o27sm9359284qkm.37.2019.08.20.20.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 20:30:27 -0700 (PDT) Date: Tue, 20 Aug 2019 23:30:26 -0400 Message-ID: <20190820233026.GC21067@t480s.localdomain> From: Vivien Didelot To: Vladimir Oltean Cc: Florian Fainelli , Andrew Lunn , Ido Schimmel , Roopa Prabhu , nikolay@cumulusnetworks.com, "David S. Miller" , netdev Subject: Re: [PATCH net-next 3/6] net: dsa: Delete the VID from the upstream port as well In-Reply-To: References: <20190820000002.9776-1-olteanv@gmail.com> <20190820000002.9776-4-olteanv@gmail.com> <20190820015138.GB975@t480s.localdomain> <20190820135213.GB11752@t480s.localdomain> <20190820165813.GB8523@t480s.localdomain> <20190820173602.GB10980@t480s.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 21 Aug 2019 01:09:39 +0300, Vladimir Oltean wrote: > I mean I made an argument already for the hack in 4/6 ("Don't program > the VLAN as pvid on the upstream port"). If the hack gets accepted > like that, I have no further need of any change in the implicit VLAN > configuration. But it's still a hack, so in that sense it would be > nicer to not need it and have a better amount of control. How come you simply cannot ignore the PVID flag for the CPU port in the driver directly, as mv88e6xxx does in preference of the Marvell specific "unmodified" mode? What PVID are you programming on the CPU port already? Thanks, Vivien