From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 027E3C3A59D for ; Thu, 22 Aug 2019 06:37:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB46621848 for ; Thu, 22 Aug 2019 06:37:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kpT4BmWB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731746AbfHVGh6 (ORCPT ); Thu, 22 Aug 2019 02:37:58 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60723 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728480AbfHVGh5 (ORCPT ); Thu, 22 Aug 2019 02:37:57 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2BC5D221B2; Thu, 22 Aug 2019 02:37:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 22 Aug 2019 02:37:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=L573PL BJrCaTdOA0EHZxJhccfPMl6Qk5YoLxHt5JUCg=; b=kpT4BmWB07a2rF5l9cd5XT sMYD/M8twpbWFSxsbDEpWRckjkK+kNKceEaoqsEj5EHz2icHI1INE7L0rhHiU1Mn /NiBrAFvxGBPekKrZYIfhTqCBLh0BKdQGTLmiC4xs6ZgigoW3gX+m4elZnZS0SAq 4MmwTG76zYVSNIzytkkrA07LN3o10AvZPA1toXxUyPNKUzaVpnCqWfckkSh6grXB JGPjykUg12ClpdgQdzlh9yPuq12Ax/y1JbZ5V8A0GSdDhHWGbAPQFOaiORRxR7ow Z8EfsbKaLKQk6f2dRowJFpJBuSWIEu4sh0Kr6qAJr+VC2waEXqGfnWjZYgvBVVKw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudeggedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefkugho ucfutghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucfkphepud elfedrgeejrdduieehrddvhedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgt hhesihguohhstghhrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 55C95D6005A; Thu, 22 Aug 2019 02:37:55 -0400 (EDT) Date: Thu, 22 Aug 2019 09:37:52 +0300 From: Ido Schimmel To: David Miller Cc: netdev@vger.kernel.org, jiri@mellanox.com, dsahern@gmail.com, mlxsw@mellanox.com, idosch@mellanox.com Subject: Re: [PATCH net-next 0/7] mlxsw: Add devlink-trap support Message-ID: <20190822063752.GA13207@splinter> References: <20190821071937.13622-1-idosch@idosch.org> <20190821.125910.2301425172924175320.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821.125910.2301425172924175320.davem@davemloft.net> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 21, 2019 at 12:59:10PM -0700, David Miller wrote: > Series applied, although that rate should really be configurable somehow. > 10Kpps seems quite arbitrary... Yes, agreed. We plan to extend the devlink-trap API to expose these trap policers and make them configurable. Thanks for the review and for shepherding the entire submission towards a more unified solution.