From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC07C3A59D for ; Thu, 22 Aug 2019 06:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B64C5233A1 for ; Thu, 22 Aug 2019 06:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731899AbfHVG66 (ORCPT ); Thu, 22 Aug 2019 02:58:58 -0400 Received: from smtpbgsg2.qq.com ([54.254.200.128]:56351 "EHLO smtpbgsg2.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731197AbfHVG65 (ORCPT ); Thu, 22 Aug 2019 02:58:57 -0400 X-QQ-mid: bizesmtp19t1566457103t0y93v7p Received: from localhost.localdomain (unknown [218.76.23.26]) by esmtp10.qq.com (ESMTP) with id ; Thu, 22 Aug 2019 14:58:17 +0800 (CST) X-QQ-SSF: 01400000000000K0JH32000A0000000 X-QQ-FEAT: YGus1B7tLZY6Td56PPA4So/HcXsjkjLQpHMm+zcGLM2RI8tGiaYm85NlJUKvs z0KsXC831a4IBeRmVn5PNPCPdChD4tYlOQcMd2yLcGRrGxSUj6VpNq5tlRiZ1fnOsSBnF5z UvRtrEUG4iK9G8nFYVAqqOwB2nWYfLRtd3kmoENSh74Or9lmx0104RqHeiuFgHwmNHNHVpT S/sZmJOBrRiRGR4NZE+TpYo6Cvs2RJyE4crAKstu4zjlxLU8p2WtYPq6l/OwkrnA2Oi7drS eKFKwV99ssNDHvyg15C5dYT1u3Ny4+OGKs8e5dN8K6o5puHL4kWuVO0+54iARWEb3kQf83F 5sYwAtd X-QQ-GoodBg: 2 From: xiaolinkui To: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, kafai@fb.com, songliubraving@fb.com, yhs@fb.com Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, xiaolinkui Subject: [PATCH] net: use unlikely for dql_avail case Date: Thu, 22 Aug 2019 14:58:16 +0800 Message-Id: <20190822065816.23619-1-xiaolinkui@kylinos.cn> X-Mailer: git-send-email 2.17.1 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:kylinos.cn:qybgforeign:qybgforeign1 X-QQ-Bgrelay: 1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is an unlikely case, use unlikely() on it seems logical. Signed-off-by: xiaolinkui --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 88292953aa6f..005f3da1b13d 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -3270,7 +3270,7 @@ static inline void netdev_tx_completed_queue(struct netdev_queue *dev_queue, */ smp_mb(); - if (dql_avail(&dev_queue->dql) < 0) + if (unlikely(dql_avail(&dev_queue->dql) < 0)) return; if (test_and_clear_bit(__QUEUE_STATE_STACK_XOFF, &dev_queue->state)) -- 2.17.1