From: Dan Carpenter <dan.carpenter@oracle.com>
To: Martin Tomes <tomesm@gmail.com>
Cc: isdn@linux-pingi.de, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] Staging: isdn/gigaset : Fix bare unsigned warnings and trailing lines errors
Date: Thu, 22 Aug 2019 15:42:49 +0300 [thread overview]
Message-ID: <20190822124249.GI4451@kadam> (raw)
In-Reply-To: <1566401259-16921-1-git-send-email-tomesm@gmail.com>
Hi Martin,
These drivers are ancient and going to be deleted soon. We're not
accepting cleanups for them at this point.
On Wed, Aug 21, 2019 at 03:27:39PM +0000, Martin Tomes wrote:
> There are many bare use of unsigned warnings and trailing statements should be on next line errors from checkpatch.pl script.
> Change the code by adding 'unsigned int'. Move 'break' statement of 'switch' command to next line.
For future reference, this should be split up so each patch fixes
one kind of style issue. And the commit message lines of text are too
long. The limit is 75 characters for commit messages (like an email).
regards,
dan carpenter
prev parent reply other threads:[~2019-08-22 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:27 [PATCH] Staging: isdn/gigaset : Fix bare unsigned warnings and trailing lines errors Martin Tomes
2019-08-22 12:42 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822124249.GI4451@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tomesm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).