From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EAF9C3A5A2 for ; Fri, 23 Aug 2019 18:26:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28DC520850 for ; Fri, 23 Aug 2019 18:26:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="mO/cdfST" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404856AbfHWS0T (ORCPT ); Fri, 23 Aug 2019 14:26:19 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:35273 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404692AbfHWS0T (ORCPT ); Fri, 23 Aug 2019 14:26:19 -0400 Received: by mail-qk1-f193.google.com with SMTP id r21so9007239qke.2 for ; Fri, 23 Aug 2019 11:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=ic2bPmp49U9Rzy6H/8n3XKjawc1Iamf9LKy2R4QYjC4=; b=mO/cdfSTCGvxNm2hVxTmeIbX0z4BjuwXIq6RV0OAHvNarrv95AY3v6XTpi594yhY7S nnFEF3KccvUWxhxFvScJaeI9PnFW2xJ98Jd/fuoDQn7iHZFgebh6kb6aB1dG+RQRleTr 3cF8R5qmY5UOTyBgHbXDpsAbiDO6f+AvesizVil3iL7UvRwwTpiBygPvp8NPZPmTxRoe D14SSsf/8C+gP8HKcsNinJX/VW/+2knO4W5WzBevX+2DtVg+57qJxmbnlmn00cg6gyz3 9nLWqnfHI8QALNp4gNuOQzI3zYXz1o3lOEEjml7HSPSuEKfG+ZaHWzebMVg6yyVYcmmD R9MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=ic2bPmp49U9Rzy6H/8n3XKjawc1Iamf9LKy2R4QYjC4=; b=EC36hYY14YniG7EGO93SwgJHXz7WtS87yDfNYXc9vGWY9vqYdsaFu+u0hK+IBxcNR4 ZZXmVcMtl+VxaGaVJiVByOjqtnLoCVeXU4y3nbHX3NFsnoojZohRaGVz5DBihS1o87OW /3C5D+xSH0frQ5zXzlxo4BWNXvzF1h3k2Il8fdFtnx3GAcNquyStogB7vKCcX4pnOFGv hssn8PiIHMvjhpOXxnYHgzLTRwdUun9ZspcQV6Mq1PGAA44KcOPLRxS60KpxmRClbIql mXSLGSKHwn1InFUTUyiKniQLIA4ERoiJJI5tkQkUTGzDDNzhVVbY/E4/WYWcFYSVuhLW LevQ== X-Gm-Message-State: APjAAAUAuNZvypgpQvhqDhZuIFGdzEBEUPwtn4+RAQxkTUxt7p8eT5m5 ADyJaRkXxZYQiNYUQlst18Bk8w== X-Google-Smtp-Source: APXvYqw3QqHpmr1xJ3t7APG0/UNZ+q0SyFowdckejxy7PLJHI93b8EoUiwSpx4co8S43qM2s7LTC+g== X-Received: by 2002:a05:620a:6cf:: with SMTP id 15mr5273647qky.98.1566584778139; Fri, 23 Aug 2019 11:26:18 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id x69sm1820881qkb.4.2019.08.23.11.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2019 11:26:18 -0700 (PDT) Date: Fri, 23 Aug 2019 11:26:07 -0700 From: Jakub Kicinski To: Vlad Buslov Cc: "netdev@vger.kernel.org" , "jhs@mojatatu.com" , "xiyou.wangcong@gmail.com" , "jiri@resnulli.us" , "davem@davemloft.net" , "pablo@netfilter.org" , Jiri Pirko , linux-doc@vger.kernel.org Subject: Re: [PATCH net-next 03/10] net: sched: refactor block offloads counter usage Message-ID: <20190823112607.1b4a69bf@cakuba.netronome.com> In-Reply-To: References: <20190822124353.16902-1-vladbu@mellanox.com> <20190822124353.16902-4-vladbu@mellanox.com> <20190822155358.0171852c@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 23 Aug 2019 10:39:50 +0000, Vlad Buslov wrote: > >> +/* Destroy filter and decrement block offload counter, if filter was previously > >> + * offloaded. > >> + */ > >> + > > > > hm.. is this gap between comment and function it pertains to > > intentional? > > Majority of function comments in cls_api.c have newline after them (not > all of them though). I don't have any strong opinions regarding this. > You suggest it is better not to have blank lines after function > comments? Ah, you're right. I think it's pretty strange to have a new line after a comment which pertains only to the function which is immediately following it. Often the new line is used as a separation, when the comment describes whole section of the file.. I kind of wish kdoc allowed none of the parameters to be described. Often you want to document the function but the parameters are kind of obvious. Anyway... feel free to leave this as is.