From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A1BCC3A59E for ; Sun, 25 Aug 2019 00:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03AF2214AF for ; Sun, 25 Aug 2019 00:02:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728353AbfHYACC (ORCPT ); Sat, 24 Aug 2019 20:02:02 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48766 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727879AbfHYACC (ORCPT ); Sat, 24 Aug 2019 20:02:02 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E43CF15263140; Sat, 24 Aug 2019 17:02:01 -0700 (PDT) Date: Sat, 24 Aug 2019 17:02:01 -0700 (PDT) Message-Id: <20190824.170201.651765358087784080.davem@davemloft.net> To: andrew@lunn.ch Cc: rmk+kernel@arm.linux.org.uk, linux@roeck-us.net, Chris.Healy@zii.aero, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: sfp: Add labels to hwmon sensors From: David Miller In-Reply-To: <20190824230417.17657-1-andrew@lunn.ch> References: <20190824230417.17657-1-andrew@lunn.ch> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 24 Aug 2019 17:02:02 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Lunn Date: Sun, 25 Aug 2019 01:04:17 +0200 > SFPs can report two different power values, the transmit power and the > receive power. Add labels to make it clear which is which. Also add > labels to the other sensors, VCC power supply, bias and module > temperature. > > sensors(1) now shows: > > sff2-isa-0000 > Adapter: ISA adapter > VCC: +3.23 V > temperature: +33.4 C > TX_power: 276.00 uW > RX_power: 20.00 uW > bias: +0.01 A > > Signed-off-by: Andrew Lunn Applied, thanks Andrew.