From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D401C3A59E for ; Sat, 24 Aug 2019 19:45:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12A0320870 for ; Sat, 24 Aug 2019 19:45:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TrzJe5qc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbfHXTpF (ORCPT ); Sat, 24 Aug 2019 15:45:05 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:39385 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727019AbfHXTpF (ORCPT ); Sat, 24 Aug 2019 15:45:05 -0400 Received: by mail-qt1-f193.google.com with SMTP id l9so14471566qtu.6 for ; Sat, 24 Aug 2019 12:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=3Hi8DLGaMoYen/EinqUwacfRJbZ+z3xP+OAMpzo+G4k=; b=TrzJe5qcZ2dYJBS8HHlrmMZ4GwUSaTFe8FHXOznCoyrwJpQ3JZo2mavzndnczWgPz8 EGk2YaYLZtat1IYq4wFk8TPU1AhJvrhVsJmrVPOfEvujGJRcg80nf6Nm+hPxdNZIDnYl wblzFtMqINW1eL0HOObjS2x8ILPv3GCysDWstxvsVf6dhMKwBigBSz63BKM80/Z9KxWh iVC6ziPuaOp6uYIqQutMOYTGZh71eTsJBM5MCZtQuoIDgkWiXFM6FkVIv2XND+83zoBq EJmVdcDtQ7oQ40JSOXPrqqkyPdE49eBPR5tRtmC5fv5OBgYdmz5NYyg90lNyANINrwRE /jEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=3Hi8DLGaMoYen/EinqUwacfRJbZ+z3xP+OAMpzo+G4k=; b=PkcKWTFq549Xrc3ZJbhKubGhTJ1xZjuA3BrrBGvSICxjomS2/bbhAgEZyzOaO5DyKm IlEwGIwQcuSg7Zb2kdyOJX6fruEGwjHVr1SCOKcodGVmYcFh0fCPXh0VlxGnjZo+7Xt5 ujP4XKwbI5+F09bLaSCaiZuTXxkAW8wZ3tw0DzCcXw/T4fwi8FkdQhXKPUeXPjSQpFCZ ZTPRl1r6JlMGrNDhHZ9N5gtDI5pefJ6aOQNoV4mhRDOeHMwOzamBiXiy8g6LR78SdX93 55SLtSZhfdJbIfS1s5bg/6e+ZsmjXEWLkORuxvAsnmIsr6091uVCcjZgtrWXjurlJ61u gprg== X-Gm-Message-State: APjAAAUUfpjxxK0IFH/6wtVcrFb63lwisw5xxKcs77zAV5rnY05LNwKq ujzcuS3vkEPEARSl1ETeKHg= X-Google-Smtp-Source: APXvYqxGpm0jhIhp/GqFVuJuc1Pt1MM2/BHmvFJZRvL8PWQeGsH9RZYRwwZOhlzE3dXjZpTEjAfDsA== X-Received: by 2002:a0c:b656:: with SMTP id q22mr9358454qvf.183.1566675904240; Sat, 24 Aug 2019 12:45:04 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id 18sm3436802qkh.77.2019.08.24.12.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Aug 2019 12:45:03 -0700 (PDT) Date: Sat, 24 Aug 2019 15:45:02 -0400 Message-ID: <20190824154502.GD32555@t480s.localdomain> From: Vivien Didelot To: Marek =?UTF-8?B?QmVow7pu?= Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , Marek =?UTF-8?B?QmVow7pu?= Subject: Re: [PATCH net-next v2 4/9] net: dsa: mv88e6xxx: create chip->info->ops->serdes_get_lane method In-Reply-To: <20190823212603.13456-5-marek.behun@nic.cz> References: <20190823212603.13456-1-marek.behun@nic.cz> <20190823212603.13456-5-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Marek, On Fri, 23 Aug 2019 23:25:58 +0200, Marek Behún wrote: > + /* SERDES lane mapping */ > + int (*serdes_get_lane)(struct mv88e6xxx_chip *chip, int port); I would prefer to keep the return code strictly for error checking as commonly used in the driver: int (*serdes_get_lane)(struct mv88e6xxx_chip *chip, int port, int *lane); Also the "lane" seems to be an address, so maybe u8 or u16 if more appropriate? Thanks, Vivien