From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF4CC3A59E for ; Sat, 24 Aug 2019 19:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83AA12082E for ; Sat, 24 Aug 2019 19:52:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GCO76439" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727792AbfHXTw5 (ORCPT ); Sat, 24 Aug 2019 15:52:57 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:45500 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727564AbfHXTw5 (ORCPT ); Sat, 24 Aug 2019 15:52:57 -0400 Received: by mail-qk1-f193.google.com with SMTP id m2so11179968qki.12 for ; Sat, 24 Aug 2019 12:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=fgUV1RFBmFzKtJsv29mzNaWXPpAf80zoXUESA1QXwF0=; b=GCO764396//DTY/MQzjUh1hrC/6fH8jNh0lYGneA5KvajWZppqvxUz2KiYuEHm8vSq I3aIJa9A1Ir9QlU+jpbHAUE6onWzwzE8rRAsFS2YnOSrdzWawVpB0vnXkth4ezYjDALa Jl4UQe2u0utufjcVT5OM5TTZzQzv8XgqyQ4bjMwe2epEr0jj+TCsZ739TBM7OKN1rThC BNBvUr38TbknamEZib4XkX41nNaHXhZgm3NtlB1q8GbAcRsNOKMsenSBt/a6B5C5ugGy gmnCcF01U8HF/oHdZMMXDMImqECzHA+bqB2WJZfFkkGCq7AlTfomeYrCieUY8QRY7Pke DI5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=fgUV1RFBmFzKtJsv29mzNaWXPpAf80zoXUESA1QXwF0=; b=E28YlopB1u0+qUPxaMiZp0blB6ecHMVICfndrh2X064zjqAMXwyvw65l0WjwC5gFP6 Mi2pweBXhwgtaAmNxVUuOBp92XhEqxkIm2Sljkf56hnib67Af1ES+l9++LsO+HePhArg 64rC5NWjOsOmdNebFnRLd867I6QzqLgGsbVUARNLe8rmKm6yrewWBhSsWplTNVJsQv1S 2Ogb/5rTqYOXK0iqr3uxtf/iw8jzOrh0JGVgJJqLQRlODsH4/wmzzMhPiPqz4+e4JU/R +L0YIb+9gGggM6qHKGw0/yJbhR7H67BPTzCGlz2oTaJkyNcHMpdhKIoDsgj1OZme38/q GlOg== X-Gm-Message-State: APjAAAUeT0pnjug5+B19y4sNKyu8XrGEoCO7o+O8sjdjoWAEmFeCiOPY sB1HTQ62i2XsYfew2sEsvRvj6gfy X-Google-Smtp-Source: APXvYqwELbOZLMdtlFHacEG8DAiDcif8Nmd0YP8gkNrmKqvjH2Q8oimZMVwBe0wZ0hubwI3+VWJQwA== X-Received: by 2002:a37:96c7:: with SMTP id y190mr9841917qkd.111.1566676376256; Sat, 24 Aug 2019 12:52:56 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id w10sm3410652qts.37.2019.08.24.12.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Aug 2019 12:52:55 -0700 (PDT) Date: Sat, 24 Aug 2019 15:52:54 -0400 Message-ID: <20190824155254.GG32555@t480s.localdomain> From: Vivien Didelot To: Marek =?UTF-8?B?QmVow7pu?= Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , Marek =?UTF-8?B?QmVow7pu?= Subject: Re: [PATCH net-next v2 4/9] net: dsa: mv88e6xxx: create chip->info->ops->serdes_get_lane method In-Reply-To: <20190824154502.GD32555@t480s.localdomain> References: <20190823212603.13456-1-marek.behun@nic.cz> <20190823212603.13456-5-marek.behun@nic.cz> <20190824154502.GD32555@t480s.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Also can you place the mv88e6xxx_serdes_get_lane() function as static inline in the serdes.h header? So that it's obvious that it's a wrapper and not a switch implementation. Ho and you can skip the 'chip->info->ops->' from the commit subject line ;-)