From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF7AC3A59E for ; Sat, 24 Aug 2019 17:54:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D21421897 for ; Sat, 24 Aug 2019 17:54:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="2BeqUA73" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727604AbfHXRyI (ORCPT ); Sat, 24 Aug 2019 13:54:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57218 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726604AbfHXRyH (ORCPT ); Sat, 24 Aug 2019 13:54:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=r5FyHDMClQMYwLelZYXhXwtSAKOswSurUUfBfPAILWc=; b=2BeqUA73cCND6h7N/XqMl4ynjR PM/6KhbxJle+0IT81Y1MS3VBhIF+2EGEYMcGeS5p8VgrGk3YtuPiUcUFAk8RmIwcKeOedqlFbRfLC Hv1b1AR4akd1c53opDQSWbET2fpNQZDhNv0ggZ+9fS6+sOORNpPxkSoGiRnhcwZU3nq8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i1aEm-000356-Hu; Sat, 24 Aug 2019 19:54:04 +0200 Date: Sat, 24 Aug 2019 19:54:04 +0200 From: Andrew Lunn To: Marek Behun Cc: netdev@vger.kernel.org, Vivien Didelot , Florian Fainelli , David Ahern , Stephen Hemminger Subject: Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support Message-ID: <20190824175404.GE8251@lunn.ch> References: <20190824024251.4542-1-marek.behun@nic.cz> <20190824152407.GA8251@lunn.ch> <20190824194546.5c436bd6@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190824194546.5c436bd6@nic.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Aug 24, 2019 at 07:45:46PM +0200, Marek Behun wrote: > On Sat, 24 Aug 2019 17:24:07 +0200 > Andrew Lunn wrote: > > > So this is all about transmit from the host out the switch. What about > > receive? How do you tell the switch which CPU interface it should use > > for a port? > > Andrew, we use the same. The DSA slave implementation of ndo_set_iflink > will also tell the switch driver to change the CPU port for that port. > Patch 3 also adds operation port_change_cpu_port to the DSA switch > operations. This is called from dsa_slave_set_iflink (at least in this > first proposal). Yes, i noticed this later. The cover letter did not include a change to a driver, so it was not clear you had considered receive, which is very much in the hard of the switch driver, not the DSA core. Andrew