From: Vladimir Oltean <olteanv@gmail.com>
To: f.fainelli@gmail.com, vivien.didelot@gmail.com, andrew@lunn.ch,
idosch@idosch.org, roopa@cumulusnetworks.com,
nikolay@cumulusnetworks.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>
Subject: [PATCH v2 net-next 0/2] Dynamic toggling of vlan_filtering for SJA1105 DSA
Date: Sun, 25 Aug 2019 21:44:52 +0300 [thread overview]
Message-ID: <20190825184454.14678-1-olteanv@gmail.com> (raw)
This patchset addresses a limitation in dsa_8021q where this sequence of
commands was causing the switch to stop forwarding traffic:
ip link add name br0 type bridge vlan_filtering 0
ip link set dev swp2 master br0
echo 1 > /sys/class/net/br0/bridge/vlan_filtering
echo 0 > /sys/class/net/br0/bridge/vlan_filtering
The issue has to do with the VLAN table manipulations that dsa_8021q
does without notifying the bridge layer. The solution is to always
restore the VLANs that the bridge knows about, when disabling tagging.
Depends on Vivien Didelot's patchset:
https://patchwork.ozlabs.org/project/netdev/list/?series=127197&state=*
Also see this discussion thread:
https://www.spinics.net/lists/netdev/msg581042.html
Vladimir Oltean (2):
net: bridge: Populate the pvid flag in br_vlan_get_info
net: dsa: tag_8021q: Restore bridge VLANs when enabling vlan_filtering
net/bridge/br_vlan.c | 2 +
net/dsa/tag_8021q.c | 91 ++++++++++++++++++++++++++++++++++----------
2 files changed, 73 insertions(+), 20 deletions(-)
--
2.17.1
next reply other threads:[~2019-08-25 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 18:44 Vladimir Oltean [this message]
2019-08-25 18:44 ` [PATCH v2 net-next 1/2] net: bridge: Populate the pvid flag in br_vlan_get_info Vladimir Oltean
2019-08-25 18:44 ` [PATCH v2 net-next 2/2] net: dsa: tag_8021q: Restore bridge VLANs when enabling vlan_filtering Vladimir Oltean
2019-08-25 18:52 ` Vladimir Oltean
2019-08-26 15:20 ` Vivien Didelot
2019-08-26 16:13 ` Vladimir Oltean
2019-08-29 11:50 ` Vladimir Oltean
2019-08-29 14:02 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190825184454.14678-1-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).