From: Vladimir Oltean <olteanv@gmail.com>
To: f.fainelli@gmail.com, vivien.didelot@gmail.com, andrew@lunn.ch,
davem@davemloft.net
Cc: netdev@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>
Subject: [PATCH net-next 0/2] Simplify DSA handling of VLAN subinterface offload
Date: Sun, 25 Aug 2019 22:46:28 +0300 [thread overview]
Message-ID: <20190825194630.12404-1-olteanv@gmail.com> (raw)
Depends on Vivien Didelot's patchset:
https://patchwork.ozlabs.org/project/netdev/list/?series=127197&state=*
This patchset removes a few strange-looking guards for -EOPNOTSUPP in
dsa_slave_vlan_rx_add_vid and dsa_slave_vlan_rx_kill_vid, making that
code path no longer possible.
It also disables the code path for the sja1105 driver, which does
support editing the VLAN table, but not hardware-accelerated VLAN
sub-interfaces, therefore the check in the DSA core would be wrong.
There was no better DSA callback to do this than .port_enable, i.e.
at ndo_open time.
Vladimir Oltean (2):
net: dsa: Advertise the VLAN offload netdev ability only if switch
supports it
net: dsa: sja1105: Clear VLAN filtering offload netdev feature
drivers/net/dsa/sja1105/sja1105_main.c | 16 ++++++++++++++++
net/dsa/slave.c | 15 ++++++---------
2 files changed, 22 insertions(+), 9 deletions(-)
--
2.17.1
next reply other threads:[~2019-08-25 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 19:46 Vladimir Oltean [this message]
2019-08-25 19:46 ` [PATCH net-next 1/2] net: dsa: Advertise the VLAN offload netdev ability only if switch supports it Vladimir Oltean
2019-08-25 19:46 ` [PATCH net-next 2/2] net: dsa: sja1105: Clear VLAN filtering offload netdev feature Vladimir Oltean
2019-08-28 3:46 ` [PATCH net-next 0/2] Simplify DSA handling of VLAN subinterface offload David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190825194630.12404-1-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).