From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA0EC3A59F for ; Mon, 26 Aug 2019 21:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1FAF217F5 for ; Mon, 26 Aug 2019 21:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727642AbfHZVEk (ORCPT ); Mon, 26 Aug 2019 17:04:40 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38174 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbfHZVEk (ORCPT ); Mon, 26 Aug 2019 17:04:40 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CB1E414FD319F; Mon, 26 Aug 2019 14:04:37 -0700 (PDT) Date: Mon, 26 Aug 2019 14:04:37 -0700 (PDT) Message-Id: <20190826.140437.926589005439320930.davem@davemloft.net> To: andrew@lunn.ch Cc: marek.behun@nic.cz, netdev@vger.kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com Subject: Re: [PATCH net-next v4 6/6] net: dsa: mv88e6xxx: fully support SERDES on Topaz family From: David Miller In-Reply-To: <20190826153830.GE2168@lunn.ch> References: <20190826122109.20660-1-marek.behun@nic.cz> <20190826122109.20660-7-marek.behun@nic.cz> <20190826153830.GE2168@lunn.ch> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 26 Aug 2019 14:04:38 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Lunn Date: Mon, 26 Aug 2019 17:38:30 +0200 >> +static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip *chip, int port, >> + phy_interface_t mode, bool allow_over_2500, >> + bool make_cmode_writable) > > I don't like these two parameters. The caller of this function can do > the check for allow_over_2500 and error out before calling this. > > Is make_cmode_writable something that could be done once at probe and > then forgotten about? Or is it needed before every write? At least > move it into the specific port_set_cmode() that requires it. Please respin this series once these issues are sorted out. Thanks.