From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A9CC3A59E for ; Mon, 26 Aug 2019 06:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA62C2190F for ; Mon, 26 Aug 2019 06:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566799250; bh=MxxkKLpj8ULmvofSbv4en0t3TH6JZHRF2MIgGRmlGMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TW3gpgZJKVQfHPoN/DswEO1D+W8vf3d9NFxyoNbsP4bzozrJEOiIR0GSaERelZC3e mCDY3QhiQCKOGnohPN1JDomEHqj0JmAdIyTwiMEtqQsPYExdwekopb0xtIyBxFkXWn 35a1nOHA86oDpes9jMvqnSBfetA8gcVN5AEbkK4U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729316AbfHZGAu (ORCPT ); Mon, 26 Aug 2019 02:00:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:58338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726606AbfHZGAt (ORCPT ); Mon, 26 Aug 2019 02:00:49 -0400 Received: from localhost (unknown [77.137.115.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F3D721848; Mon, 26 Aug 2019 06:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566799249; bh=MxxkKLpj8ULmvofSbv4en0t3TH6JZHRF2MIgGRmlGMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j/9Ff9bKvhMLwhyo98FL1C1rpKT7amLIPZ6SsswsNN+B1o1EB4EqfEC1rzldKf2Qk Hi1qZ7oRx8TQYJivM90m8y8gs5f8Us3tCZxqS04i3fiW/izisMoHrV6PXnwDqZo6gW XpjFDYNNEkT7jisvhWct2KO12Qpt4jolqRQFpg5s= Date: Mon, 26 Aug 2019 09:00:45 +0300 From: Leon Romanovsky To: Michael Chan Cc: davem@davemloft.net, netdev@vger.kernel.org, vasundhara-v.volam@broadcom.com, jiri@mellanox.com, ray.jui@broadcom.com Subject: Re: [PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable(). Message-ID: <20190826060045.GA4584@mtr-leonro.mtl.com> References: <1566791705-20473-1-git-send-email-michael.chan@broadcom.com> <1566791705-20473-4-git-send-email-michael.chan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566791705-20473-4-git-send-email-michael.chan@broadcom.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Aug 25, 2019 at 11:54:54PM -0400, Michael Chan wrote: > Refactor the hardware/firmware configuration portion in > bnxt_sriov_enable() into a new function bnxt_cfg_hw_sriov(). This > new function can be called after a firmware reset to reconfigure the > VFs previously enabled. I wonder what does it mean for already bound VFs to vfio driver? Will you rebind them as well? Can I assume that FW error in one VF will trigger "restart" of other VFs too? Thanks