From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102A1C3A59F for ; Mon, 26 Aug 2019 15:13:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5E9E2173E for ; Mon, 26 Aug 2019 15:13:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="xqk1PNSD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732929AbfHZPNi (ORCPT ); Mon, 26 Aug 2019 11:13:38 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:59958 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732908AbfHZPNh (ORCPT ); Mon, 26 Aug 2019 11:13:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xjOV5S9SAyl37qb9P12m0i6tKRdc5ijmgkhnR7b5i4w=; b=xqk1PNSDJOOAfT7xBaJxFRiJbK aAOjlymmjM5RcU6cOTZZLnpHKgGZNWdKI8MEMe5+LkxTm9YQa8q3++1hfscIuklYVF4WLxh8AJQM4 7+pcjt8SaGmhILdzECjkxZSjE0qplxOTv6MQraPHI+aqscBB591yKCnjjz6d51k/za98=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i2GgZ-0004Uz-D7; Mon, 26 Aug 2019 17:13:35 +0200 Date: Mon, 26 Aug 2019 17:13:35 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, Vivien Didelot , Florian Fainelli , Vladimir Oltean Subject: Re: [PATCH net-next v4 1/6] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler Message-ID: <20190826151335.GA2168@lunn.ch> References: <20190826122109.20660-1-marek.behun@nic.cz> <20190826122109.20660-2-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190826122109.20660-2-marek.behun@nic.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 26, 2019 at 02:21:04PM +0200, Marek Behún wrote: > The mv88e6390_serdes_irq_link_sgmii IRQ handler reads the SERDES PHY > status register to determine speed, among other things. If cmode of the > port is set to 2500base-x, though, the PHY still reports 1000 Mbps (the > PHY register itself does not differentiate between 1000 Mbps and 2500 > Mbps - it thinks it is running at 1000 Mbps, although clock is 2.5x > faster). > Look at the cmode and set SPEED_2500 if cmode is set to 2500base-x. > Also tell mv88e6xxx_port_setup_mac the PHY interface mode corresponding > to current cmode in terms of phy_interface_t. > > Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn Andrew