From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62302C3A59F for ; Mon, 26 Aug 2019 15:30:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A42723405 for ; Mon, 26 Aug 2019 15:30:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0U2+DkrA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732402AbfHZPaA (ORCPT ); Mon, 26 Aug 2019 11:30:00 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60020 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728965AbfHZPaA (ORCPT ); Mon, 26 Aug 2019 11:30:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kAHW+kOmK6fLXUCF/KHfYUc9Kn2L35s8LPXMyaepik4=; b=0U2+DkrAslAEzpBZntfx8RZRQg 7zncWf3zNv8iEHmeaFHP0vVCJ8uUYSRn9rcWhI3Ztc+rTDyaCDTbHolbMBNB9INaZplzU/ibqCCi9 yWseC28BtqMsSSzCFPzRNX25CrMPLY8fSK5lNmxy2jN3PjY4pAB74VtQSqxcS2tSzV6Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i2GwQ-0004cW-1Y; Mon, 26 Aug 2019 17:29:58 +0200 Date: Mon, 26 Aug 2019 17:29:58 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, Vivien Didelot , Florian Fainelli , Vladimir Oltean Subject: Re: [PATCH net-next v4 4/6] net: dsa: mv88e6xxx: simplify SERDES code for Topaz and Peridot Message-ID: <20190826152958.GD2168@lunn.ch> References: <20190826122109.20660-1-marek.behun@nic.cz> <20190826122109.20660-5-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190826122109.20660-5-marek.behun@nic.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 26, 2019 at 02:21:07PM +0200, Marek Behún wrote: > By adding an additional serdes_get_lane implementation (for Topaz), we > can merge the implementations of other SERDES functions (powering and > IRQs). We can skip checking port numbers, since the serdes_get_lane() > methods inform if there is no lane on a port or if the lane cannot be > used for given cmode. > > Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn Andrew