From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58AECC3A5A4 for ; Mon, 26 Aug 2019 18:47:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 325802070B for ; Mon, 26 Aug 2019 18:47:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="NxdnwwNC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387400AbfHZSr2 (ORCPT ); Mon, 26 Aug 2019 14:47:28 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60506 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732007AbfHZSr2 (ORCPT ); Mon, 26 Aug 2019 14:47:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3SctyFfS3yLn1lHEdyI1Kmom1XhY5J/W6bf5Yp9jBk8=; b=NxdnwwNC6gy91psyhP3LpADnOt KowX/CZGwKAahaI/D87i4FITICTVSiOGY4G928NklYtshAJ0hNMa5egvajC4/p6J7LWzi2Z6SyXZt +m8PtTOvJ4r580w9m3M4V38H8PCmaYRpXfY3kWQ6W2RJ+oWiEmFjnkT7nuA/IVpq+2fs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i2K1P-00067N-EL; Mon, 26 Aug 2019 20:47:19 +0200 Date: Mon, 26 Aug 2019 20:47:19 +0200 From: Andrew Lunn To: Voon Weifeng Cc: "David S. Miller" , Maxime Coquelin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Abreu , Giuseppe Cavallaro , Alexandre Torgue , Ong Boon Leong Subject: Re: [PATCH v1 net-next] net: stmmac: Add support for MDIO interrupts Message-ID: <20190826184719.GF2168@lunn.ch> References: <1566870320-9825-1-git-send-email-weifeng.voon@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566870320-9825-1-git-send-email-weifeng.voon@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 27, 2019 at 09:45:20AM +0800, Voon Weifeng wrote: > From: "Chuah, Kim Tatt" > > DW EQoS v5.xx controllers added capability for interrupt generation > when MDIO interface is done (GMII Busy bit is cleared). > This patch adds support for this interrupt on supported HW to avoid > polling on GMII Busy bit. > > stmmac_mdio_read() & stmmac_mdio_write() will sleep until wake_up() is > called by the interrupt handler. Hi Voon I _think_ there are some order of operation issues here. The mdiobus is registered in the probe function. As soon as of_mdiobus_register() is called, the MDIO bus must work. At that point MDIO read/writes can start to happen. As far as i can see, the interrupt handler is only requested in stmmac_open(). So it seems like any MDIO operations after probe, but before open are going to fail? Thanks Andrew