From: Marek Behun <marek.behun@nic.cz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net-next v4 6/6] net: dsa: mv88e6xxx: fully support SERDES on Topaz family
Date: Mon, 26 Aug 2019 19:31:25 +0200 [thread overview]
Message-ID: <20190826193125.4c94662e@nic.cz> (raw)
In-Reply-To: <20190826153830.GE2168@lunn.ch>
On Mon, 26 Aug 2019 17:38:30 +0200
Andrew Lunn <andrew@lunn.ch> wrote:
> > +static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip *chip, int port,
> > + phy_interface_t mode, bool allow_over_2500,
> > + bool make_cmode_writable)
>
> I don't like these two parameters. The caller of this function can do
> the check for allow_over_2500 and error out before calling this.
>
> Is make_cmode_writable something that could be done once at probe and
> then forgotten about? Or is it needed before every write? At least
> move it into the specific port_set_cmode() that requires it.
>
> Thanks
> Andrew
Btw those two additional parameters were modeled as in
static int mv88e6xxx_port_set_speed(struct mv88e6xxx_chip *chip,
int port, int speed, bool alt_bit,
bool force_bit);
next prev parent reply other threads:[~2019-08-26 17:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 12:21 [PATCH net-next v4 0/6] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes Marek Behún
2019-08-26 12:21 ` [PATCH net-next v4 1/6] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler Marek Behún
2019-08-26 15:13 ` Andrew Lunn
2019-08-26 12:21 ` [PATCH net-next v4 2/6] net: dsa: mv88e6xxx: update code operating on hidden registers Marek Behún
2019-08-26 15:20 ` Andrew Lunn
2019-08-26 12:21 ` [PATCH net-next v4 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation Marek Behún
2019-08-26 15:28 ` Andrew Lunn
2019-08-26 12:21 ` [PATCH net-next v4 4/6] net: dsa: mv88e6xxx: simplify SERDES code for Topaz and Peridot Marek Behún
2019-08-26 15:29 ` Andrew Lunn
2019-08-26 12:21 ` [PATCH net-next v4 5/6] net: dsa: mv88e6xxx: rename port cmode macro Marek Behún
2019-08-26 12:21 ` [PATCH net-next v4 6/6] net: dsa: mv88e6xxx: fully support SERDES on Topaz family Marek Behún
2019-08-26 15:38 ` Andrew Lunn
2019-08-26 17:27 ` Marek Behun
2019-08-26 17:44 ` Vivien Didelot
2019-08-26 17:52 ` Marek Behun
2019-08-26 17:59 ` [PATCH RFC] " Marek Behún
2019-08-26 18:03 ` Marek Behun
2019-08-26 18:28 ` Vivien Didelot
2019-08-26 18:36 ` Marek Behun
2019-08-26 18:53 ` Vivien Didelot
2019-08-26 17:31 ` Marek Behun [this message]
2019-08-26 17:50 ` [PATCH net-next v4 6/6] " Vivien Didelot
2019-08-26 21:04 ` David Miller
2019-08-26 15:06 ` [PATCH net-next v4 0/6] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826193125.4c94662e@nic.cz \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).