From: Marek Behun <marek.behun@nic.cz>
To: Vivien Didelot <vivien.didelot@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH RFC] net: dsa: mv88e6xxx: fully support SERDES on Topaz family
Date: Mon, 26 Aug 2019 20:36:14 +0200 [thread overview]
Message-ID: <20190826203614.6f9f6a8d@nic.cz> (raw)
In-Reply-To: <20190826142809.GC9628@t480s.localdomain>
On Mon, 26 Aug 2019 14:28:09 -0400
Vivien Didelot <vivien.didelot@gmail.com> wrote:
> Ask yourself what is the single task achieved by this function, and name this
> operation accordingly. It seems to change the CMODE to be writable, only
> supported by certain switch models right? So in addition to port_get_cmode
> and port_set_cmode, you can add port_set_cmode_writable, and call it right
> before or after port_set_cmode in mv88e6xxx_port_setup_mac.
Andrew's complaint was also about this function being called every time
cmode is to be changed. The cmode does need to be made writable only
once. In this sense it does make sense to put into into
mv88e6xxx_setup_port.
> Also please address the last comment I made in v3 in the new series.
I shall.
next prev parent reply other threads:[~2019-08-26 18:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 12:21 [PATCH net-next v4 0/6] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes Marek Behún
2019-08-26 12:21 ` [PATCH net-next v4 1/6] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler Marek Behún
2019-08-26 15:13 ` Andrew Lunn
2019-08-26 12:21 ` [PATCH net-next v4 2/6] net: dsa: mv88e6xxx: update code operating on hidden registers Marek Behún
2019-08-26 15:20 ` Andrew Lunn
2019-08-26 12:21 ` [PATCH net-next v4 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation Marek Behún
2019-08-26 15:28 ` Andrew Lunn
2019-08-26 12:21 ` [PATCH net-next v4 4/6] net: dsa: mv88e6xxx: simplify SERDES code for Topaz and Peridot Marek Behún
2019-08-26 15:29 ` Andrew Lunn
2019-08-26 12:21 ` [PATCH net-next v4 5/6] net: dsa: mv88e6xxx: rename port cmode macro Marek Behún
2019-08-26 12:21 ` [PATCH net-next v4 6/6] net: dsa: mv88e6xxx: fully support SERDES on Topaz family Marek Behún
2019-08-26 15:38 ` Andrew Lunn
2019-08-26 17:27 ` Marek Behun
2019-08-26 17:44 ` Vivien Didelot
2019-08-26 17:52 ` Marek Behun
2019-08-26 17:59 ` [PATCH RFC] " Marek Behún
2019-08-26 18:03 ` Marek Behun
2019-08-26 18:28 ` Vivien Didelot
2019-08-26 18:36 ` Marek Behun [this message]
2019-08-26 18:53 ` Vivien Didelot
2019-08-26 17:31 ` [PATCH net-next v4 6/6] " Marek Behun
2019-08-26 17:50 ` Vivien Didelot
2019-08-26 21:04 ` David Miller
2019-08-26 15:06 ` [PATCH net-next v4 0/6] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826203614.6f9f6a8d@nic.cz \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).