From: David Miller <davem@davemloft.net>
To: olivier.tilmans@nokia-bell-labs.com
Cc: eric.dumazet@gmail.com, stephen@networkplumber.org,
olga@albisser.org, koen.de_schepper@nokia-bell-labs.com,
research@bobbriscoe.net, henrist@henrist.net, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v5] sched: Add dualpi2 qdisc
Date: Tue, 27 Aug 2019 15:03:19 -0700 (PDT) [thread overview]
Message-ID: <20190827.150319.716294283021335199.davem@davemloft.net> (raw)
In-Reply-To: <20190822080045.27609-1-olivier.tilmans@nokia-bell-labs.com>
From: "Tilmans, Olivier (Nokia - BE/Antwerp)" <olivier.tilmans@nokia-bell-labs.com>
Date: Thu, 22 Aug 2019 08:10:48 +0000
> +static inline struct dualpi2_skb_cb *dualpi2_skb_cb(struct sk_buff *skb)
Please do not use the inline keyword in foo.c files, let the compiler decide.
> +static struct sk_buff *dualpi2_qdisc_dequeue(struct Qdisc *sch)
> +{
> + struct dualpi2_sched_data *q = qdisc_priv(sch);
> + struct sk_buff *skb;
> + int qlen_c, credit_change;
Reverse christmas tree here, please.
> +static void dualpi2_timer(struct timer_list *timer)
> +{
> + struct dualpi2_sched_data *q = from_timer(q, timer, pi2.timer);
> + struct Qdisc *sch = q->sch;
> + spinlock_t *root_lock; /* Lock to access the head of both queues. */
Likewise, and please remove this comment it makes the variable declarations
look odd.
prev parent reply other threads:[~2019-08-27 22:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 8:10 [PATCH net-next v5] sched: Add dualpi2 qdisc Tilmans, Olivier (Nokia - BE/Antwerp)
2019-08-22 20:33 ` Dave Taht
2019-08-23 12:59 ` Tilmans, Olivier (Nokia - BE/Antwerp)
[not found] ` <bded966b-5176-69c8-4ac3-70d81d344c22@bobbriscoe.net>
2019-08-28 16:55 ` Dave Taht
2019-08-29 22:18 ` Bob Briscoe
2019-08-27 22:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827.150319.716294283021335199.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=henrist@henrist.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olga@albisser.org \
--cc=olivier.tilmans@nokia-bell-labs.com \
--cc=research@bobbriscoe.net \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox