From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F26AC3A5A3 for ; Wed, 28 Aug 2019 03:17:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A32B205C9 for ; Wed, 28 Aug 2019 03:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726278AbfH1DRz (ORCPT ); Tue, 27 Aug 2019 23:17:55 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54140 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726206AbfH1DRy (ORCPT ); Tue, 27 Aug 2019 23:17:54 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 71AAA153B8312; Tue, 27 Aug 2019 20:17:54 -0700 (PDT) Date: Tue, 27 Aug 2019 20:17:53 -0700 (PDT) Message-Id: <20190827.201753.619474113830630076.davem@davemloft.net> To: olteanv@gmail.com Cc: vivien.didelot@gmail.com, netdev@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next v2 0/6] net: dsa: explicit programmation of VLAN on CPU ports From: David Miller In-Reply-To: References: <20190825172520.22798-1-vivien.didelot@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 27 Aug 2019 20:17:54 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean Date: Sun, 25 Aug 2019 21:27:23 +0300 > On Sun, 25 Aug 2019 at 20:25, Vivien Didelot wrote: >> >> When a VLAN is programmed on a user port, every switch of the fabric also >> program the CPU ports and the DSA links as part of the VLAN. To do that, >> DSA makes use of bitmaps to prepare all members of a VLAN. >> >> While this is expected for DSA links which are used as conduit between >> interconnected switches, only the dedicated CPU port of the slave must be >> programmed, not all CPU ports of the fabric. This may also cause problems in >> other corners of DSA such as the tag_8021q.c driver, which needs to program >> its ports manually, CPU port included. >> >> We need the dsa_port_vlan_{add,del} functions and its dsa_port_vid_{add,del} >> variants to simply trigger the VLAN programmation without any logic in them, >> but they may currently skip the operation based on the bridge device state. >> >> This patchset gets rid of the bitmap operations, and moves the bridge device >> check as well as the explicit programmation of CPU ports where they belong, >> in the slave code. >> >> While at it, clear the VLAN flags before programming a CPU port, as it >> doesn't make sense to forward the PVID flag for example for such ports. >> >> Changes in v2: only clear the PVID flag. ... > For the whole series: > Tested-by: Vladimir Oltean > Thanks! Series applied.