From: Steffen Klassert <steffen.klassert@secunet.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>, <davem@davemloft.net>
Subject: Re: [PATCH net] xfrm: add NETDEV_UNREGISTER event process for xfrmi
Date: Tue, 27 Aug 2019 08:58:13 +0200 [thread overview]
Message-ID: <20190827065813.GX2879@gauss3.secunet.de> (raw)
In-Reply-To: <fce85b872c03cee379cb30ae46100ff42bea8e0d.1566807905.git.lucien.xin@gmail.com>
On Mon, Aug 26, 2019 at 04:25:05PM +0800, Xin Long wrote:
> When creating a xfrmi dev, it always holds the phydev. The xfrmi dev should
> be deleted when the phydev is being unregistered, so that the phydev can be
> put on time. Otherwise the phydev's deleting will get stuck:
>
> # ip link add dummy10 type dummy
> # ip link add xfrmi10 type xfrm dev dummy10
> # ip link del dummy10
>
> The last command blocks and dmesg shows:
>
> unregister_netdevice: waiting for dummy10 to become free. Usage count = 1
>
> This patch fixes it by adding NETDEV_UNREGISTER event process for xfrmi.
There is already a patch in the ipsec tree that fixes this issue
in a different way. Please base xfrm patches on the ipsec/ipsec-next
tree to avoid double work.
Thanks anyway!
prev parent reply other threads:[~2019-08-27 6:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 8:25 [PATCH net] xfrm: add NETDEV_UNREGISTER event process for xfrmi Xin Long
2019-08-27 6:58 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827065813.GX2879@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox