From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Chun-Hao Lin <hau@realtek.com>
Subject: Re: [PATCH net-next 1/4] r8169: prepare for adding RTL8125 support
Date: Wed, 28 Aug 2019 01:27:13 +0200 [thread overview]
Message-ID: <20190827232713.GE26248@lunn.ch> (raw)
In-Reply-To: <66ac2b09-ea87-a4ba-f6f3-1885e9587298@gmail.com>
On Tue, Aug 27, 2019 at 08:41:00PM +0200, Heiner Kallweit wrote:
> This patch prepares the driver for adding RTL8125 support:
> - change type of interrupt mask to u32
> - restrict rtl_is_8168evl_up to RTL8168 chip versions
> - factor out reading MAC address from registers
> - re-add function rtl_get_events
> - move disabling interrupt coalescing to RTL8169/RTL8168 init
> - read different register for PCI commit
> - don't use bit LastFrag in tx descriptor after send, RTL8125 clears it
Hi Heiner
That is a lot of changes in one patch. Although there is no planned
functional change, r8169 has a habit of breaking. Having lots of small
changes would help tracking down which change caused a breakage, via a
git bisect.
So you might want to consider splitting this up into a number of small
patches.
Andrew
next prev parent reply other threads:[~2019-08-27 23:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 18:40 [PATCH net-next 0/4] r8169: add support for RTL8125 Heiner Kallweit
2019-08-27 18:41 ` [PATCH net-next 1/4] r8169: prepare for adding RTL8125 support Heiner Kallweit
2019-08-27 23:27 ` Andrew Lunn [this message]
2019-08-28 5:52 ` Heiner Kallweit
2019-08-27 18:41 ` [PATCH net-next 2/4] r8169: add support for RTL8125 Heiner Kallweit
2019-08-27 18:42 ` [PATCH net-next 3/4] r8169: add RTL8125 PHY initialization Heiner Kallweit
2019-08-27 18:42 ` [PATCH net-next 4/4] r8169: add support for EEE on RTL8125 Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827232713.GE26248@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hau@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).