From: David Miller <davem@davemloft.net>
To: gvrose8192@gmail.com
Cc: netdev@vger.kernel.org, pshelar@ovn.org, joe@wand.net.nz
Subject: Re: [PATCH V3 net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments
Date: Wed, 28 Aug 2019 14:54:09 -0700 (PDT) [thread overview]
Message-ID: <20190828.145409.412910250799244993.davem@davemloft.net> (raw)
In-Reply-To: <1566917890-22304-1-git-send-email-gvrose8192@gmail.com>
From: Greg Rose <gvrose8192@gmail.com>
Date: Tue, 27 Aug 2019 07:58:09 -0700
> When IP fragments are reassembled before being sent to conntrack, the
> key from the last fragment is used. Unless there are reordering
> issues, the last fragment received will not contain the L4 ports, so the
> key for the reassembled datagram won't contain them. This patch updates
> the key once we have a reassembled datagram.
>
> The handle_fragments() function works on L3 headers so we pull the L3/L4
> flow key update code from key_extract into a new function
> 'key_extract_l3l4'. Then we add a another new function
> ovs_flow_key_update_l3l4() and export it so that it is accessible by
> handle_fragments() for conntrack packet reassembly.
>
> Co-authored by: Justin Pettit <jpettit@ovn.org>
> Signed-off-by: Greg Rose <gvrose8192@gmail.com>
Applied with Co-authored-by fixed.
next prev parent reply other threads:[~2019-08-28 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 14:58 [PATCH V3 net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments Greg Rose
2019-08-27 14:58 ` [PATCH V3 net 2/2] openvswitch: Clear the L4 portion of the key for "later" fragments Greg Rose
2019-08-28 0:33 ` Pravin Shelar
2019-08-28 21:54 ` David Miller
2019-08-28 0:33 ` [PATCH V3 net 1/2] openvswitch: Properly set L4 keys on "later" IP fragments Pravin Shelar
2019-08-28 4:19 ` Gregory Rose
2019-08-28 21:54 ` David Miller [this message]
2019-08-28 23:47 ` Gregory Rose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828.145409.412910250799244993.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gvrose8192@gmail.com \
--cc=joe@wand.net.nz \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox