From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: multipath tcp MIB counter placement - share with tcp or extra?
Date: Wed, 28 Aug 2019 14:32:02 +0200 [thread overview]
Message-ID: <20190828123202.GI20113@breakpoint.cc> (raw)
In-Reply-To: <deb00e41-0188-0ca9-ccb3-b74b34a4cc5d@gmail.com>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > Let me know -- I can go with a separate MIB, its no problem, I just want
> > to avoid going down the wrong path.
>
> There are about 40 counters.
>
> Space for that will be per netns : num_possible_cpus * 40 * 8 bytes
>
> The cost of folding all the values will make nstat slower even if MPTCP is not used.
Ok, so 'same proc file' would be fine but 'increase pcpu mem cost
unconditionally' isn't.
> Maybe find a way to not having to fold the MPTCP percpu counters if MPTCP is not loaded ?
MPTCP is builtin (bool).
However, we might be able to delay allocation until first mptcp socket
is requested, I will see if this can be done somehow.
Thanks Eric!
prev parent reply other threads:[~2019-08-28 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 11:43 multipath tcp MIB counter placement - share with tcp or extra? Florian Westphal
2019-08-28 12:27 ` Eric Dumazet
2019-08-28 12:32 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828123202.GI20113@breakpoint.cc \
--to=fw@strlen.de \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).