From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Hillf Danton <hdanton@sina.com>
Cc: john.fastabend@gmail.com,
syzbot <syzbot+7a6ee4d0078eac6bf782@syzkaller.appspotmail.com>,
aviadye@mellanox.com, borisp@mellanox.com, daniel@iogearbox.net,
davejwatson@fb.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: general protection fault in tls_sk_proto_close (2)
Date: Thu, 29 Aug 2019 09:43:43 -0700 [thread overview]
Message-ID: <20190829094343.0248c61c@cakuba.netronome.com> (raw)
In-Reply-To: <20190829035200.3340-1-hdanton@sina.com>
On Thu, 29 Aug 2019 11:52:00 +0800, Hillf Danton wrote:
> Alternatively work is done if sock is closed again. Anyway ctx is reset
> under sock's callback lock in write mode.
>
> --- a/net/tls/tls_main.c
> +++ b/net/tls/tls_main.c
> @@ -295,6 +295,8 @@ static void tls_sk_proto_close(struct so
> long timeo = sock_sndtimeo(sk, 0);
> bool free_ctx;
>
> + if (!ctx)
> + return;
> if (ctx->tx_conf == TLS_SW)
> tls_sw_cancel_work_tx(ctx);
That's no bueno, the real socket's close will never get called.
next prev parent reply other threads:[~2019-08-29 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 6:38 general protection fault in tls_sk_proto_close (2) syzbot
2019-08-28 22:26 ` Jakub Kicinski
[not found] ` <20190829035200.3340-1-hdanton@sina.com>
2019-08-29 16:43 ` Jakub Kicinski [this message]
2019-08-29 18:48 ` John Fastabend
2019-08-29 18:53 ` Jakub Kicinski
2019-08-29 22:18 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829094343.0248c61c@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=hdanton@sina.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+7a6ee4d0078eac6bf782@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox