From: Stephen Hemminger <stephen@networkplumber.org>
To: Aya Levin <ayal@mellanox.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>
Subject: Re: [iproute2, master 1/2] devlink: Print health reporter's dump time-stamp in a helper function
Date: Thu, 29 Aug 2019 16:25:38 -0700 [thread overview]
Message-ID: <20190829162533.25606191@hermes.lan> (raw)
In-Reply-To: <1566471942-28529-2-git-send-email-ayal@mellanox.com>
On Thu, 22 Aug 2019 14:05:41 +0300
Aya Levin <ayal@mellanox.com> wrote:
> Add pr_out_dump_reporter prefix to the helper function's name and
> encapsulate the print in it.
>
> Fixes: 2f1242efe9d0 ("devlink: Add devlink health show command")
> Signed-off-by: Aya Levin <ayal@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
Looks fine, but devlink needs to be converted from doing JSON
printing its own way and use common iproute2 libraries.
next prev parent reply other threads:[~2019-08-30 0:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 8:17 [net] devlink: Add method for time-stamp on reporter's dump Aya Levin
2019-08-22 11:05 ` [iproute2, master 0/2] Fix reporter's dump's time-stamp Aya Levin
2019-08-22 11:05 ` [iproute2, master 1/2] devlink: Print health reporter's dump time-stamp in a helper function Aya Levin
2019-08-29 23:25 ` Stephen Hemminger [this message]
2019-09-06 7:17 ` Aya Levin
2019-08-22 11:05 ` [iproute2, master 2/2] devlink: Add a new time-stamp format for health reporter's dump Aya Levin
2019-08-29 23:27 ` Stephen Hemminger
2019-09-06 7:17 ` Aya Levin
2019-08-22 14:06 ` [net] devlink: Add method for time-stamp on " Andrew Lunn
2019-08-22 17:40 ` Ido Schimmel
2019-08-22 19:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829162533.25606191@hermes.lan \
--to=stephen@networkplumber.org \
--cc=ayal@mellanox.com \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).