From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, vishal@chelsio.com, saeedm@mellanox.com,
jiri@resnulli.us
Subject: Re: [PATCH 0/4 net-next] flow_offload: update mangle action representation
Date: Thu, 29 Aug 2019 18:54:48 -0700 [thread overview]
Message-ID: <20190829185448.0b502af8@cakuba.netronome.com> (raw)
In-Reply-To: <20190830005336.23604-1-pablo@netfilter.org>
On Fri, 30 Aug 2019 02:53:32 +0200, Pablo Neira Ayuso wrote:
> * Offsets do not need to be on the 32-bits boundaries anymore. This
> patchset adds front-end code to adjust the offset and length coming
> from the tc pedit representation, so drivers get an exact header field
> offset and length.
But drivers use offsetof(start of field) to match headers, and I don't
see you changing that. So how does this work then?
Say - I want to change the second byte of an IPv4 address.
> * The front-end coalesces consecutive pedit actions into one single
> word, so drivers can mangle IPv6 and ethernet address fields in one
> single go.
You still only coalesce up to 16 bytes, no?
As I said previously drivers will continue to implement mangle action
merge code if that's the case. It'd be nice if core did the coalescing,
and mark down first and last action, in case there is a setup cost for
rewrite group.
next prev parent reply other threads:[~2019-08-30 1:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 0:53 [PATCH 0/4 net-next] flow_offload: update mangle action representation Pablo Neira Ayuso
2019-08-30 0:53 ` [PATCH net-next 1/4] net: flow_offload: flip mangle action mask Pablo Neira Ayuso
2019-08-30 0:53 ` [PATCH net-next 2/4] net: flow_offload: bitwise AND on mangle action value field Pablo Neira Ayuso
2019-08-30 0:53 ` [PATCH net-next 3/4] net: flow_offload: mangle action at byte level Pablo Neira Ayuso
2019-08-30 15:28 ` Vlad Buslov
2019-08-30 0:53 ` [PATCH net-next 4/4] netfilter: nft_payload: packet mangling offload support Pablo Neira Ayuso
2019-08-30 1:54 ` Jakub Kicinski [this message]
2019-08-30 9:07 ` [PATCH 0/4 net-next] flow_offload: update mangle action representation Pablo Neira Ayuso
2019-08-30 22:33 ` Jakub Kicinski
2019-08-31 14:22 ` Pablo Neira Ayuso
2019-09-01 20:47 ` Jakub Kicinski
2019-09-03 0:05 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829185448.0b502af8@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=saeedm@mellanox.com \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).