From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70646C3A59B for ; Fri, 30 Aug 2019 20:33:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 514282343A for ; Fri, 30 Aug 2019 20:33:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728225AbfH3Udj (ORCPT ); Fri, 30 Aug 2019 16:33:39 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41460 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727304AbfH3Udi (ORCPT ); Fri, 30 Aug 2019 16:33:38 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 04055154FB632; Fri, 30 Aug 2019 13:33:37 -0700 (PDT) Date: Fri, 30 Aug 2019 13:33:35 -0700 (PDT) Message-Id: <20190830.133335.323827182628557013.davem@davemloft.net> To: zdai@linux.vnet.ibm.com Cc: xiyou.wangcong@gmail.com, jhs@mojatatu.com, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zdai@us.ibm.com Subject: Re: [v2] net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate From: David Miller In-Reply-To: <1567195432.20025.18.camel@oc5348122405> References: <1567191974-11578-1-git-send-email-zdai@linux.vnet.ibm.com> <1567195432.20025.18.camel@oc5348122405> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 30 Aug 2019 13:33:38 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "David Z. Dai" Date: Fri, 30 Aug 2019 15:03:52 -0500 > I have the impression that last parameter num value should be larger > than the attribute num value in 2nd parameter (TC_POLICE_RATE64 in this > case). The argument in question is explicitly the "padding" value. Please explain in detail where you got the impression that the argument has to be larger?