From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 05/15] net: sgi: ioc3-eth: allocate space for desc rings only once
Date: Fri, 30 Aug 2019 10:09:26 +0200 [thread overview]
Message-ID: <20190830100926.343e7c2c7f3cd059c359bdd4@suse.de> (raw)
In-Reply-To: <20190829150504.68a04fe4@cakuba.netronome.com>
On Thu, 29 Aug 2019 15:05:04 -0700
Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> On Fri, 30 Aug 2019 00:00:58 +0200, Thomas Bogendoerfer wrote:
> > Out of curiosity does kcalloc/kmalloc_array give me the same guarantees about
> > alignment ? rx ring needs to be 4KB aligned, tx ring 16KB aligned.
>
> I don't think so, actually, I was mostly worried you are passing
> address from get_page() into kfree() here ;) But patch 11 cures that,
> so that's good, too.
I realized that after sending my last mail. I'll fix that in v3 even
it's just a transient bug.
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 247165 (AG München)
Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2019-08-30 8:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 15:49 [PATCH v2 net-next 00/15] ioc3-eth improvements Thomas Bogendoerfer
2019-08-29 15:49 ` [PATCH v2 net-next 01/15] MIPS: SGI-IP27: remove ioc3 ethernet init Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 02/15] MIPS: SGI-IP27: restructure ioc3 register access Thomas Bogendoerfer
2019-08-29 21:26 ` Shannon Nelson
2019-08-29 15:50 ` [PATCH v2 net-next 03/15] net: sgi: ioc3-eth: remove checkpatch errors/warning Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 04/15] net: sgi: ioc3-eth: use defines for constants dealing with desc rings Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 05/15] net: sgi: ioc3-eth: allocate space for desc rings only once Thomas Bogendoerfer
2019-08-29 21:05 ` Jakub Kicinski
2019-08-29 22:00 ` Thomas Bogendoerfer
2019-08-29 22:05 ` Jakub Kicinski
2019-08-30 8:09 ` Thomas Bogendoerfer [this message]
2019-08-29 15:50 ` [PATCH v2 net-next 06/15] net: sgi: ioc3-eth: get rid of ioc3_clean_rx_ring() Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 07/15] net: sgi: ioc3-eth: separate tx and rx ring handling Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 08/15] net: sgi: ioc3-eth: introduce chip start function Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 09/15] net: sgi: ioc3-eth: split ring cleaning/freeing and allocation Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 10/15] net: sgi: ioc3-eth: refactor rx buffer allocation Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 11/15] net: sgi: ioc3-eth: use dma-direct for dma allocations Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 12/15] net: sgi: ioc3-eth: use csum_fold Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 13/15] net: sgi: ioc3-eth: Fix IPG settings Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 14/15] net: sgi: ioc3-eth: protect emcr in all cases Thomas Bogendoerfer
2019-08-29 15:50 ` [PATCH v2 net-next 15/15] net: sgi: ioc3-eth: no need to stop queue set_multicast_list Thomas Bogendoerfer
2019-08-29 21:15 ` [PATCH v2 net-next 00/15] ioc3-eth improvements Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830100926.343e7c2c7f3cd059c359bdd4@suse.de \
--to=tbogendoerfer@suse.de \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox