From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, ioana.ciornei@nxp.com
Subject: Re: [PATCH net-next 0/3] dpaa2-eth: Add new statistics counters
Date: Fri, 30 Aug 2019 23:12:19 -0700 [thread overview]
Message-ID: <20190830231219.2363758a@cakuba.netronome.com> (raw)
In-Reply-To: <1567160443-31297-1-git-send-email-ruxandra.radulescu@nxp.com>
On Fri, 30 Aug 2019 13:20:40 +0300, Ioana Radulescu wrote:
> Recent firmware versions offer access to more DPNI statistics
> counters. Add the relevant ones to ethtool interface stats.
>
> Also we can now make use of a new counter for in flight egress frames
> to avoid sleeping an arbitrary amount of time in the ndo_stop routine.
A little messy there in the comment of patch 2, and IMHO if you're
expecting particular errors to be ignored it's better to write:
if (err == -EOPNOTSUPP)
/* still fine*/;
else if (err)
/* real err */
than assume any error is for unsupported and add a extra comment
explaining that things may be not supported.
Series LGTM tho.
next prev parent reply other threads:[~2019-08-31 6:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 10:20 [PATCH net-next 0/3] dpaa2-eth: Add new statistics counters Ioana Radulescu
2019-08-30 10:20 ` [PATCH net-next 1/3] dpaa2-eth: Minor refactoring in ethtool stats Ioana Radulescu
2019-08-30 10:20 ` [PATCH net-next 2/3] dpaa2-eth: Add new DPNI statistics counters Ioana Radulescu
2019-08-30 10:20 ` [PATCH net-next 3/3] dpaa2-eth: Poll Tx pending frames counter on if down Ioana Radulescu
2019-08-31 6:12 ` Jakub Kicinski [this message]
2019-09-01 6:42 ` [PATCH net-next 0/3] dpaa2-eth: Add new statistics counters David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830231219.2363758a@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox