From: Mauro Rodrigues <maurosr@linux.vnet.ibm.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org, nhorman@redhat.com,
sassmann@redhat.com, Andrew Bowers <andrewx.bowers@intel.com>
Subject: Re: [net-next 11/15] i40e: Implement debug macro hw_dbg using pr_debug
Date: Mon, 2 Sep 2019 14:24:33 -0300 [thread overview]
Message-ID: <20190902172433.GA8007@kashyyyk> (raw)
In-Reply-To: <20190828153936.57ababbc@cakuba.netronome.com>
On Wed, Aug 28, 2019 at 03:39:53PM -0700, Jakub Kicinski wrote:
> On Tue, 27 Aug 2019 23:44:03 -0700, Jeff Kirsher wrote:
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_osdep.h b/drivers/net/ethernet/intel/i40e/i40e_osdep.h
> > index a07574bff550..c0c9ce3eab23 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_osdep.h
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_osdep.h
> > @@ -18,7 +18,12 @@
> > * actual OS primitives
> > */
> >
> > -#define hw_dbg(hw, S, A...) do {} while (0)
> > +#define hw_dbg(hw, S, A...) \
> > +do { \
> > + int domain = pci_domain_nr(((struct i40e_pf *)(hw)->back)->pdev->bus); \
> > + pr_debug("i40e %04x:%02x:%02x.%x " S, domain, (hw)->bus.bus_id, \
> > + (hw)->bus.device, (hw)->bus.func, ## A); \
>
> This looks like open coded dev_dbg() / dev_namie(), why?
Indeed, thanks for pointing out. I'll fix this and the other patch you
reviewed and resubmit.
I'm not sure what should be the preferred approach here though, just use
dev_dbg to implement this macro or replace all of its occurrence in the
code by dev_dbg?
Jeff, do you have any preference?
>
> > +} while (0)
next prev parent reply other threads:[~2019-09-02 17:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 6:43 [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2019-08-27 Jeff Kirsher
2019-08-28 6:43 ` [net-next 01/15] iavf: remove unused debug function iavf_debug_d Jeff Kirsher
2019-08-28 6:43 ` [net-next 02/15] ixgbevf: Link lost in VM on ixgbevf when restoring from freeze or suspend Jeff Kirsher
2019-08-28 6:43 ` [net-next 03/15] e1000e: Make speed detection on hotplugging cable more reliable Jeff Kirsher
2019-08-28 6:43 ` [net-next 04/15] igc: Remove useless forward declaration Jeff Kirsher
2019-08-28 6:43 ` [net-next 05/15] Documentation: iavf: Update the Intel LAN driver doc for iavf Jeff Kirsher
2019-08-28 6:43 ` [net-next 06/15] fm10k: use a local variable for the frag pointer Jeff Kirsher
2019-08-28 6:43 ` [net-next 07/15] igc: Add NVM checksum validation Jeff Kirsher
2019-08-28 6:44 ` [net-next 08/15] iavf: allow permanent MAC address to change Jeff Kirsher
2019-08-28 6:44 ` [net-next 09/15] igc: Remove unneeded PCI bus defines Jeff Kirsher
2019-08-28 6:44 ` [net-next 10/15] i40e: fix hw_dbg usage in i40e_hmc_get_object_va Jeff Kirsher
2019-08-28 22:38 ` Jakub Kicinski
2019-08-28 6:44 ` [net-next 11/15] i40e: Implement debug macro hw_dbg using pr_debug Jeff Kirsher
2019-08-28 22:39 ` Jakub Kicinski
2019-09-02 17:24 ` Mauro Rodrigues [this message]
2019-08-28 6:44 ` [net-next 12/15] i40e: Remove EMPR traces from debugfs facility Jeff Kirsher
2019-08-28 6:44 ` [net-next 13/15] ixgbe: sync the first fragment unconditionally Jeff Kirsher
2019-08-28 22:40 ` Jakub Kicinski
2019-08-28 6:44 ` [net-next 14/15] igc: Add tx_csum offload functionality Jeff Kirsher
2019-08-28 6:44 ` [net-next 15/15] i40e: Add support for X710 device Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902172433.GA8007@kashyyyk \
--to=maurosr@linux.vnet.ibm.com \
--cc=andrewx.bowers@intel.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox