From: Dominique Martinet <asmadeus@codewreck.org>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: 9p: Fix possible null-pointer dereferences in p9_cm_event_handler()
Date: Tue, 3 Sep 2019 12:55:23 +0200 [thread overview]
Message-ID: <20190903105523.GA29600@nautica> (raw)
In-Reply-To: <20190724125545.GA12982@nautica>
Jia-Ju,
Dominique Martinet wrote on Wed, Jul 24, 2019:
> Jia-Ju Bai wrote on Wed, Jul 24, 2019:
> > In p9_cm_event_handler(), there is an if statement on 260 to check
> > whether rdma is NULL, which indicates that rdma can be NULL.
> > If so, using rdma->xxx may cause a possible null-pointer dereference.
>
> The final dereference (complete(&rdma->cm_done) line 285) has been here
> from the start, so we would have seen crashes by now if rdma could be
> null at this point.
>
> Let's do it the other way around and remove the useless "if (rdma)" that
> has been here from day 1 instead ; I basically did the same with
> c->status a few months ago (from a coverity report)...
Did you get anywhere with this, or should I submit a new patch myself ?
In the later case I'll tag this as Reported-by you
Thanks,
--
Dominique
prev parent reply other threads:[~2019-09-03 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 10:39 [PATCH] net: 9p: Fix possible null-pointer dereferences in p9_cm_event_handler() Jia-Ju Bai
2019-07-24 12:55 ` Dominique Martinet
2019-09-03 10:55 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903105523.GA29600@nautica \
--to=asmadeus@codewreck.org \
--cc=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).