From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79735C3A5A2 for ; Tue, 3 Sep 2019 13:16:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 568CC2053B for ; Tue, 3 Sep 2019 13:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729373AbfICNQa (ORCPT ); Tue, 3 Sep 2019 09:16:30 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:41623 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729090AbfICNQ3 (ORCPT ); Tue, 3 Sep 2019 09:16:29 -0400 Received: from cpe-2606-a000-111b-43ee-0-0-0-162e.dyn6.twc.com ([2606:a000:111b:43ee::162e] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1i58fU-00063D-Tk; Tue, 03 Sep 2019 09:16:25 -0400 Date: Tue, 3 Sep 2019 09:15:53 -0400 From: Neil Horman To: Xin Long Cc: network dev , linux-sctp@vger.kernel.org, davem@davemloft.net, Marcelo Ricardo Leitner Subject: Re: [PATCH net] sctp: use transport pf_retrans in sctp_do_8_2_transport_strike Message-ID: <20190903131553.GC30429@hmswarspite.think-freely.org> References: <41769d6033d27d629798e060671a3b21f22e2a21.1567437861.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41769d6033d27d629798e060671a3b21f22e2a21.1567437861.git.lucien.xin@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Sep 02, 2019 at 11:24:21PM +0800, Xin Long wrote: > Transport should use its own pf_retrans to do the error_count > check, instead of asoc's. Otherwise, it's meaningless to make > pf_retrans per transport. > > Fixes: 5aa93bcf66f4 ("sctp: Implement quick failover draft from tsvwg") > Signed-off-by: Xin Long > --- > net/sctp/sm_sideeffect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c > index 1cf5bb5..e52b212 100644 > --- a/net/sctp/sm_sideeffect.c > +++ b/net/sctp/sm_sideeffect.c > @@ -547,7 +547,7 @@ static void sctp_do_8_2_transport_strike(struct sctp_cmd_seq *commands, > if (net->sctp.pf_enable && > (transport->state == SCTP_ACTIVE) && > (transport->error_count < transport->pathmaxrxt) && > - (transport->error_count > asoc->pf_retrans)) { > + (transport->error_count > transport->pf_retrans)) { > > sctp_assoc_control_transport(asoc, transport, > SCTP_TRANSPORT_PF, > -- > 2.1.0 > > Acked-by: Neil Horman