From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02DE8C3A5A2 for ; Tue, 3 Sep 2019 13:38:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCF8D2343A for ; Tue, 3 Sep 2019 13:38:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="XO1qSstP"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="I6HEaAHY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729435AbfICNip (ORCPT ); Tue, 3 Sep 2019 09:38:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50744 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727005AbfICNin (ORCPT ); Tue, 3 Sep 2019 09:38:43 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8B9BD6025A; Tue, 3 Sep 2019 13:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567517922; bh=ej069zxmm9FbOAIunXcS+l57Bk7LOELm9ibfNx23sA8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=XO1qSstPVykmMPstFDLagfancdpch3VXv9ZMCWrmcVBcRrlb67aQmoKMwDKSnWklo xgOMyq98tKll+8Znge4Ucp2/9uRAih0i3QsnawRjUNIOywW4iSkxG0hKYxjxmnbwYW PosY9fzlT7tsWhdAHcjWlZLBldR8NKZyONwLkCA0= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 45E496025A; Tue, 3 Sep 2019 13:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567517922; bh=ej069zxmm9FbOAIunXcS+l57Bk7LOELm9ibfNx23sA8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=I6HEaAHYPOzMcZJ3O/nnMRCvNnXSrYspLAyfEsxmP/ZKHtEdWjzsEdE4D82iXe/3u Rfe43h+jZf8Hoci4A4dTcmbM1MiDKFcgwdA5OoxS8IuPXEo91NS+tM8FStk4LyYkrd Pi7FCUBTj5PTqRjKiyhDCY6SCRap+Y/6ww82jVLo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 45E496025A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] brcmfmac: remove redundant assignment to pointer hash From: Kalle Valo In-Reply-To: <20190809172217.1809-1-colin.king@canonical.com> References: <20190809172217.1809-1-colin.king@canonical.com> To: Colin King Cc: Arend van Spriel , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S . Miller" , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190903133842.8B9BD6025A@smtp.codeaurora.org> Date: Tue, 3 Sep 2019 13:38:42 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The pointer hash is being initialized with a value that is never read > and is being re-assigned a little later on. The assignment is > redundant and hence can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 73c742bb9c9b brcmfmac: remove redundant assignment to pointer hash -- https://patchwork.kernel.org/patch/11087385/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches