From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E2BC3A59E for ; Wed, 4 Sep 2019 06:08:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FB982339D for ; Wed, 4 Sep 2019 06:08:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="ju3nP+nI"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="hqY0g/pw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728668AbfIDGIC (ORCPT ); Wed, 4 Sep 2019 02:08:02 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52384 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbfIDGIC (ORCPT ); Wed, 4 Sep 2019 02:08:02 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1FDD460863; Wed, 4 Sep 2019 06:08:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567577281; bh=A5jxgUwpEQdGcpUrgTBp7J90qN5hLJxxlg5AJOlfIYw=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ju3nP+nIT9JobGjhVXro7zxQqFIoHkfT8P4bqRjXNxhT0Y7jf0NjypR7XAHW3iiGI 6Yz2HqV+Rs3j/TNc97UnPPuWTWE/m8vqCcvnBthzm1KEOKmrrJNhVi5uIT9Q4IDt90 RAsIk3CUngOz79pfMtr5TXv2MlCo87CFtdX08S1U= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id AF42860863; Wed, 4 Sep 2019 06:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567577280; bh=A5jxgUwpEQdGcpUrgTBp7J90qN5hLJxxlg5AJOlfIYw=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=hqY0g/pwJZmTrVTa0oArHt2OE2P5q67htDxuWaCEFNvxPrHloIRDCsXKzPWXMwMGG RHF8+MZOHnOz1mfm+m2KlIng0yxrhaC13uJJMGllfbOR2Xt3/StASgTx49JyiDuuQI ljE4Y+5Hk4BsdOB1wrvO1C4P4YN9za+ryH6bH3s4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AF42860863 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] wil6210: Delete an unnecessary kfree() call in wil_tid_ampdu_rx_alloc() From: Kalle Valo In-Reply-To: References: To: Markus Elfring Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, wil6210@qti.qualcomm.com, "David S. Miller" , Maya Erez , LKML , kernel-janitors@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190904060801.1FDD460863@smtp.codeaurora.org> Date: Wed, 4 Sep 2019 06:08:01 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Markus Elfring wrote: > A null pointer would be passed to a call of the function “kfree” > directly after a call of the function “kcalloc” failed at one place. > Remove this superfluous function call. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > Reviewed-by: Maya Erez > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. d20b1e6c8307 wil6210: Delete an unnecessary kfree() call in wil_tid_ampdu_rx_alloc() -- https://patchwork.kernel.org/patch/11117119/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches