From: Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
vedang.patel@intel.com,
Richard Cochran <richardcochran@gmail.com>,
weifeng.voon@intel.com, jiri@mellanox.com, m-karicheri2@ti.com,
Jose.Abreu@synopsys.com,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
xiyou.wangcong@gmail.com, netdev <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH v2 net-next 10/15] net: dsa: Pass ndo_setup_tc slave callback to drivers
Date: Wed, 4 Sep 2019 09:31:42 +0200 [thread overview]
Message-ID: <20190904073142.GB8133@linutronix.de> (raw)
In-Reply-To: <CA+h21hoVv0SwFf8=MS_SZf85QsObrNKQf_w_p=j_97i16psjDQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
Hi Vladimir,
On Mon, Sep 02, 2019 at 11:49:30AM +0300, Vladimir Oltean wrote:
> I did something similar in v1 with a .port_setup_taprio in "[RFC PATCH
> net-next 3/6] net: dsa: Pass tc-taprio offload to drivers".
Okay, didn't see that one.
> Would this address Ilias's comment about DSA not really needing to
> have this level of awareness into the qdisc offload type? Rightfully I
> can agree that the added-value of making a .port_set_schedule and
> .port_del_schedule in DSA compared to simply passing the ndo_setup_tc
> is not that great.
I wanted to avoid that drivers have to the same kind of work, and it put
it therefore into the core part. However, I agree that the added-value
is not that high for TAPRIO.
>
> By the way, thanks for the iproute2 patch for parsing 64-bit base time
> on ARM 32, saved me a bit of debugging time :)
No problem :). That cost me a bit of time.
> Regards,
> -Vladimir
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-04 7:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 0:46 [RFC PATCH v2 net-next 00/15] tc-taprio offload for SJA1105 DSA Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 01/15] net: dsa: sja1105: Change the PTP command access pattern Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 02/15] net: dsa: sja1105: Get rid of global declaration of struct ptp_clock_info Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 03/15] net: dsa: sja1105: Switch to hardware operations for PTP Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 04/15] net: dsa: sja1105: Implement the .gettimex64 system call " Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 05/15] net: dsa: sja1105: Restore PTP time after switch reset Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 06/15] net: dsa: sja1105: Disallow management xmit during " Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 07/15] net: dsa: sja1105: Move PTP data to its own private structure Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 08/15] net: dsa: sja1105: Advertise the 8 TX queues Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 09/15] taprio: Add support for hardware offloading Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 10/15] net: dsa: Pass ndo_setup_tc slave callback to drivers Vladimir Oltean
2019-09-02 7:52 ` Kurt Kanzenbach
2019-09-02 8:49 ` Vladimir Oltean
2019-09-04 7:31 ` Kurt Kanzenbach [this message]
2019-08-30 0:46 ` [RFC PATCH v2 net-next 11/15] net: dsa: sja1105: Add static config tables for scheduling Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 12/15] net: dsa: sja1105: Configure the Time-Aware Scheduler via tc-taprio offload Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 13/15] net: dsa: sja1105: Make HOSTPRIO a kernel config Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 14/15] net: dsa: sja1105: Make the PTP command read-write Vladimir Oltean
2019-08-30 0:46 ` [RFC PATCH v2 net-next 15/15] net: dsa: sja1105: Implement state machine for TAS with PTP clock source Vladimir Oltean
2019-08-30 1:21 ` [RFC PATCH v2 net-next 00/15] tc-taprio offload for SJA1105 DSA Jakub Kicinski
2019-08-30 10:11 ` Vladimir Oltean
2019-08-30 22:28 ` Jakub Kicinski
2019-08-31 17:03 ` Vladimir Oltean
2019-08-31 19:41 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904073142.GB8133@linutronix.de \
--to=kurt.kanzenbach@linutronix.de \
--cc=Jose.Abreu@synopsys.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=richardcochran@gmail.com \
--cc=vedang.patel@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=vivien.didelot@gmail.com \
--cc=weifeng.voon@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).