From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B913AC3A5A8 for ; Wed, 4 Sep 2019 09:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 963CD22CF7 for ; Wed, 4 Sep 2019 09:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729615AbfIDJuv (ORCPT ); Wed, 4 Sep 2019 05:50:51 -0400 Received: from elvis.franken.de ([193.175.24.41]:33489 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbfIDJuv (ORCPT ); Wed, 4 Sep 2019 05:50:51 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1i5Rw8-00008U-00; Wed, 04 Sep 2019 11:50:48 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 3CA8EC2782; Wed, 4 Sep 2019 11:50:40 +0200 (CEST) Date: Wed, 4 Sep 2019 11:50:40 +0200 From: Thomas Bogendoerfer To: Mao Wenan Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] net: sonic: remove dev_kfree_skb before return NETDEV_TX_BUSY Message-ID: <20190904095040.GA12628@alpha.franken.de> References: <20190904094211.117454-1-maowenan@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190904094211.117454-1-maowenan@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 04, 2019 at 05:42:11PM +0800, Mao Wenan wrote: > When dma_map_single is failed to map buffer, skb can't be freed > before sonic driver return to stack with NETDEV_TX_BUSY, because > this skb may be requeued to qdisc, it might trigger use-after-free. > > Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers") > Signed-off-by: Mao Wenan > --- > drivers/net/ethernet/natsemi/sonic.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c > index d0a01e8f000a..248a8f22a33b 100644 > --- a/drivers/net/ethernet/natsemi/sonic.c > +++ b/drivers/net/ethernet/natsemi/sonic.c > @@ -233,7 +233,6 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev) > laddr = dma_map_single(lp->device, skb->data, length, DMA_TO_DEVICE); > if (!laddr) { > printk(KERN_ERR "%s: failed to map tx DMA buffer.\n", dev->name); > - dev_kfree_skb(skb); > return NETDEV_TX_BUSY; > } Reviewed-by: Thomas Bogendoerfer Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]