From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0A7C3A5A5 for ; Thu, 5 Sep 2019 09:54:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 711942184B for ; Thu, 5 Sep 2019 09:54:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732638AbfIEJyt (ORCPT ); Thu, 5 Sep 2019 05:54:49 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43882 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725290AbfIEJys (ORCPT ); Thu, 5 Sep 2019 05:54:48 -0400 Received: from localhost (unknown [89.248.140.11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2432C1538752B; Thu, 5 Sep 2019 02:54:46 -0700 (PDT) Date: Thu, 05 Sep 2019 11:54:42 +0200 (CEST) Message-Id: <20190905.115442.77056976071115136.davem@davemloft.net> To: mdf@kernel.org Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc; From: David Miller In-Reply-To: <20190903184652.3148-1-mdf@kernel.org> References: <20190903184652.3148-1-mdf@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Sep 2019 02:54:48 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Moritz Fischer Date: Tue, 3 Sep 2019 11:46:52 -0700 > Add forward declaration for struct gpio_desc in order to address > the following: > > ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror] > ./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration, which is probably not what you want [-Werror] > > Fixes commit 71bd106d2567 ("net: fixed-phy: Add > fixed_phy_register_with_gpiod() API") > Signed-off-by: Moritz Fischer Applied with Fixes tag fixed up.