From: Andrew Lunn <andrew@lunn.ch>
To: "Voon, Weifeng" <weifeng.voon@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jose Abreu <joabreu@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>
Subject: Re: [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts
Date: Thu, 5 Sep 2019 08:40:02 +0200 [thread overview]
Message-ID: <20190905064002.GB415@lunn.ch> (raw)
In-Reply-To: <D6759987A7968C4889FDA6FA91D5CBC81475C23E@PGSMSX103.gar.corp.intel.com>
>
> The change log is near the end of the patch:
> /**
> --
> Changelog v2
> *mdio interrupt mode or polling mode will depends on mdio interrupt enable bit
> *Disable the mdio interrupt enable bit in stmmac_release
> *Remove the condition for initialize wait queues
> *Applied reverse Christmas tree
> 1.9.1
At the end, nobody sees it, because everybody else does it at the beginning.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=submitting#the-canonical-patch-format
This talks about the ---. David prefers to see the change log before
the ---. Other maintainers want it after the ---.
>
> >
> > The formatting of this patch also looks a bit odd. Did you use git
> > format-patch ; git send-email?
>
> Yes, I do git format-patch, then ./scripts/checkpatch.pl.
> Lastly git send-email
What looked odd is the missing --- marker. git format-patch should of
create that as part of the patch.
Andrew
next prev parent reply other threads:[~2019-09-05 6:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 14:02 [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts Voon Weifeng
2019-09-04 14:58 ` Andrew Lunn
2019-09-05 1:23 ` Voon, Weifeng
2019-09-05 6:40 ` Andrew Lunn [this message]
2019-09-05 11:58 ` Voon, Weifeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905064002.GB415@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).