From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA6DC43331 for ; Fri, 6 Sep 2019 20:01:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07E68208C3 for ; Fri, 6 Sep 2019 20:01:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="6XCzVQF3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388396AbfIFUB6 (ORCPT ); Fri, 6 Sep 2019 16:01:58 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60516 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbfIFUB5 (ORCPT ); Fri, 6 Sep 2019 16:01:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5BA/udfx9tiiu/UaXuycBkGhbsM3ggiscOGSuK3nHuQ=; b=6XCzVQF3Wn3ZeAW22eNF0wYkob 93Im1AtTPuX4jf/Paj8SYD95WB3J7O2cNyi9BV4qHww3EGeX1cbE72ytRtg+loi5Qq28FPH8hPWoz vRnYTSqmJhtRZH87tWJvWBZbPDSXC2PxvdDM4DgwdBSk7yJNCEsb9DjyDn1hDxaxuLzw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i6KQb-0001HI-8z; Fri, 06 Sep 2019 22:01:53 +0200 Date: Fri, 6 Sep 2019 22:01:53 +0200 From: Andrew Lunn To: Claudiu Manoil Cc: "David S . Miller" , alexandru.marginean@nxp.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 3/5] enetc: Initialize SerDes for SGMII and SXGMII protocols Message-ID: <20190906200153.GE2339@lunn.ch> References: <1567779344-30965-1-git-send-email-claudiu.manoil@nxp.com> <1567779344-30965-4-git-send-email-claudiu.manoil@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567779344-30965-4-git-send-email-claudiu.manoil@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 06, 2019 at 05:15:42PM +0300, Claudiu Manoil wrote: > +int enetc_imdio_init(struct enetc_pf *pf) > +{ > + struct device *dev = &pf->si->pdev->dev; > + struct enetc_mdio_priv *mdio_priv; > + struct mii_bus *bus; > + int err; > + > + bus = devm_mdiobus_alloc_size(dev, sizeof(*mdio_priv)); > + if (!bus) > + return -ENOMEM; > + > + bus->name = "FSL ENETC internal MDIO Bus"; > + bus->read = enetc_mdio_read; > + bus->write = enetc_mdio_write; > + bus->parent = dev; Hi Claudiu Since you don't expect any PHYs to be on this bus, maybe you should set bus->phy_mask; Andrew