From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
Simon Horman <simon.horman@netronome.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [net-next 02/11] devlink: add 'reset_dev_on_drv_probe' param
Date: Fri, 6 Sep 2019 21:17:30 -0700 [thread overview]
Message-ID: <20190906211730.5c362b48@cakuba.netronome.com> (raw)
In-Reply-To: <8066ba35-2f9b-c175-100f-e754b4ca65be@netronome.com>
On Fri, 6 Sep 2019 11:40:54 -0700, Dirk van der Merwe wrote:
> >> DEVLINK_PARAM_RESET_DEV_VALUE_UNKNOWN (0)
> >> + Unknown or invalid value.
> > Why do you need this? Do you have usecase for this value?
>
> I added this in to avoid having the entire netlink dump fail when there
> are invalid values read from hardware.
>
> This way, it can report an unknown or invalid value instead of failing
> the operation.
That's the first reason, the second is that we also want to report
the unknown value if it's not recognized by the driver. For u8/enum
parameters the value may possibly be set to a value older driver
doesn't understand, but users should still be able to set them to one
of the known ones.
We'd also like to add that to 'fw_load_policy'. WDYT?
next prev parent reply other threads:[~2019-09-07 4:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 16:00 [net-next 00/11] nfp: implement firmware loading policy Simon Horman
2019-09-06 16:00 ` [net-next 01/11] devlink: extend 'fw_load_policy' values Simon Horman
2019-09-06 16:00 ` [net-next 02/11] devlink: add 'reset_dev_on_drv_probe' param Simon Horman
2019-09-06 18:31 ` Jiri Pirko
2019-09-06 18:40 ` Dirk van der Merwe
2019-09-07 4:17 ` Jakub Kicinski [this message]
2019-09-07 10:28 ` Jiri Pirko
2019-09-06 16:00 ` [net-next 03/11] nfp: nsp: add support for fw_loaded command Simon Horman
2019-09-06 16:00 ` [net-next 04/11] nfp: nsp: add support for optional hwinfo lookup Simon Horman
2019-09-06 16:00 ` [net-next 05/11] nfp: nsp: add support for hwinfo set operation Simon Horman
2019-09-06 16:00 ` [net-next 06/11] nfp: honor FW reset and loading policies Simon Horman
2019-09-06 16:00 ` [net-next 07/11] nfp: add devlink param infrastructure Simon Horman
2019-09-06 16:00 ` [net-next 08/11] nfp: devlink: add 'fw_load_policy' support Simon Horman
2019-09-06 16:00 ` [net-next 09/11] nfp: devlink: add 'reset_dev_on_drv_probe' support Simon Horman
2019-09-06 16:01 ` [net-next 10/11] kdoc: fix nfp_fw_load documentation Simon Horman
2019-09-06 16:01 ` [net-next 11/11] Documentation: nfp: add nfp driver specific notes Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906211730.5c362b48@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox