From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A378C43331 for ; Sat, 7 Sep 2019 15:28:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07DCF206A5 for ; Sat, 7 Sep 2019 15:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389424AbfIGP2l (ORCPT ); Sat, 7 Sep 2019 11:28:41 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46136 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730957AbfIGP2k (ORCPT ); Sat, 7 Sep 2019 11:28:40 -0400 Received: from localhost (unknown [88.214.184.0]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F3DA91528CDC7; Sat, 7 Sep 2019 08:28:38 -0700 (PDT) Date: Sat, 07 Sep 2019 17:28:37 +0200 (CEST) Message-Id: <20190907.172837.1868098969790314376.davem@davemloft.net> To: jiri@resnulli.us Cc: netdev@vger.kernel.org, idosch@mellanox.com, dsahern@gmail.com, mlxsw@mellanox.com Subject: Re: [patch net-next] net: fib_notifier: move fib_notifier_ops from struct net into per-net struct From: David Miller In-Reply-To: <20190905180656.4756-1-jiri@resnulli.us> References: <20190905180656.4756-1-jiri@resnulli.us> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Sep 2019 08:28:40 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Date: Thu, 5 Sep 2019 20:06:56 +0200 > From: Jiri Pirko > > No need for fib_notifier_ops to be in struct net. It is used only by > fib_notifier as a private data. Use net_generic to introduce per-net > fib_notifier struct and move fib_notifier_ops there. > > Signed-off-by: Jiri Pirko Applied.