From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03BE5C43331 for ; Sat, 7 Sep 2019 15:48:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE9C4218AC for ; Sat, 7 Sep 2019 15:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436491AbfIGPsR convert rfc822-to-8bit (ORCPT ); Sat, 7 Sep 2019 11:48:17 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46380 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390962AbfIGPsQ (ORCPT ); Sat, 7 Sep 2019 11:48:16 -0400 Received: from localhost (unknown [88.214.184.0]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4CCE0152F1AD7; Sat, 7 Sep 2019 08:48:14 -0700 (PDT) Date: Sat, 07 Sep 2019 17:48:12 +0200 (CEST) Message-Id: <20190907.174812.440810335403861625.davem@davemloft.net> To: zenczykowski@gmail.com Cc: maze@google.com, netdev@vger.kernel.org, dsahern@gmail.com, lorenzo@google.com, edumazet@google.com Subject: Re: [PATCH] net-ipv6: addrconf_f6i_alloc - fix non-null pointer check to !IS_ERR() From: David Miller In-Reply-To: <20190906035637.47097-1-zenczykowski@gmail.com> References: <20190906035637.47097-1-zenczykowski@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-2 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Sep 2019 08:48:16 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maciej Żenczykowski Date: Thu, 5 Sep 2019 20:56:37 -0700 > From: Maciej Żenczykowski > > Fixes a stupid bug I recently introduced... > ip6_route_info_create() returns an ERR_PTR(err) and not a NULL on error. > > Fixes: d55a2e374a94 ("net-ipv6: fix excessive RTF_ADDRCONF flag on ::1/128 local route (and others)'") > Cc: David Ahern > Cc: Lorenzo Colitti > Cc: Eric Dumazet > Signed-off-by: Maciej Żenczykowski Applied and queued up for -stable since I queued up the patch this fixes.