From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
davejwatson@fb.com, borisp@mellanox.com, aviadye@mellanox.com,
john.fastabend@gmail.com, daniel@iogearbox.net
Subject: Re: [PATCH net-next 0/4] net/tls: small TX offload optimizations
Date: Sat, 07 Sep 2019 18:11:29 +0200 (CEST) [thread overview]
Message-ID: <20190907.181129.1814581845232128155.davem@davemloft.net> (raw)
In-Reply-To: <20190907053000.23869-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 6 Sep 2019 22:29:56 -0700
> Hi!
>
> This set brings small TLS TX device optimizations. The biggest
> gain comes from fixing a misuse of non temporal copy instructions.
> On a synthetic workload modelled after customer's RFC application
> I see 3-5% percent gain.
Series applied.
But if history is any indication I'd watch for how much this actually
helps or hurts universally. We once tried to use non-temporal stores
for sendmsg/recvmsg copies and had to turn that off because it only
helped in certain situations on certain cpus and hurt in others.
prev parent reply other threads:[~2019-09-07 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 5:29 [PATCH net-next 0/4] net/tls: small TX offload optimizations Jakub Kicinski
2019-09-07 5:29 ` [PATCH net-next 1/4] net/tls: unref frags in order Jakub Kicinski
2019-09-07 5:29 ` [PATCH net-next 2/4] net/tls: use RCU for the adder to the offload record list Jakub Kicinski
2019-09-07 5:29 ` [PATCH net-next 3/4] net/tls: remove the record tail optimization Jakub Kicinski
2019-09-07 5:30 ` [PATCH net-next 4/4] net/tls: align non temporal copy to cache lines Jakub Kicinski
2019-09-07 16:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190907.181129.1814581845232128155.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=davejwatson@fb.com \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox