From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9028CC43331 for ; Sat, 7 Sep 2019 15:58:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68D4F218AC for ; Sat, 7 Sep 2019 15:58:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="SgzlbGJd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394738AbfIGP6M (ORCPT ); Sat, 7 Sep 2019 11:58:12 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33204 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389788AbfIGP6L (ORCPT ); Sat, 7 Sep 2019 11:58:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BPFXfTuuawVcjqRBXwYB+uvmu3LaIBpabNB/L8tEuH4=; b=SgzlbGJd4j88MtGVS43gBMnuLu XKe4CVre5r5GJddgaZVQi1ahyys42kNPIRfYtUqus9TOytgAJLnx+bF8qftjE4+PGzmRyFrETbfbV Gm65NRetYptC8o2hohyjqIKhIFErcabz0tRZC9eI6/GGRJLY5jketl66+TSVy4al1gi8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i6d6D-0006Bx-KJ; Sat, 07 Sep 2019 17:58:05 +0200 Date: Sat, 7 Sep 2019 17:58:05 +0200 From: Andrew Lunn To: zhong jiang Cc: davem@davemloft.net, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ethernet: micrel: Use DIV_ROUND_CLOSEST directly to make it readable Message-ID: <20190907155805.GE21922@lunn.ch> References: <1567698828-26825-1-git-send-email-zhongjiang@huawei.com> <20190906194050.GB2339@lunn.ch> <5D732078.6080902@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5D732078.6080902@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Sep 07, 2019 at 11:14:00AM +0800, zhong jiang wrote: > On 2019/9/7 3:40, Andrew Lunn wrote: > > On Thu, Sep 05, 2019 at 11:53:48PM +0800, zhong jiang wrote: > >> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d > >> but is perhaps more readable. > > Hi Zhong > > > > Did you find this by hand, or did you use a tool. If a tool is used, > > it is normal to give some credit to the tool. > With the following help of Coccinelle. It is good to mention Coccinelle or other such tools. They often exist because of university research work, and funding for such tools does depend on publicity of the tools, getting the credit they deserve. Andrew